Fix rpc_benchmark and add fcall mode #6173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nb-ohad
force-pushed
the
ohad-add-fcall-mode-to-rpc-benchmark
branch
from
b7a7f74
to
561d14a
Compare
guymguym
reviewed
Sep 22, 2020
src/rpc/rpc_benchmark.js
Outdated
| @@ -110,14 +117,15 @@ schema.compile(); | |||
|
|
|||
| // create rpc | |||
| const rpc = new RPC({ | |||
| schema: schema, | |||
| client_factory: api.client_factory_from_schema(schema), | |||
There was a problem hiding this comment.
Hmm, I want to make sure rpc module is usable even without api module.
Do you think this can be done?
There was a problem hiding this comment.
Ok we have it now in a sepetate PR: #6178
We can wait to merge this one untill the other one is merged
There was a problem hiding this comment.
Rebased against master and removed dependency with the api module
guymguym
approved these changes
Sep 22, 2020
nb-ohad
force-pushed
the
ohad-add-fcall-mode-to-rpc-benchmark
branch
2 times, most recently
from
61a933a
to
9f9d9c6
Compare
guymguym
approved these changes
Sep 24, 2020
|
No, as this change was merged to master after the fcall changes |
Also move the start promise chain to async/await Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
nb-ohad
force-pushed
the
ohad-add-fcall-mode-to-rpc-benchmark
branch
from
9f9d9c6
to
767e785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
--fcallflag to test RPC overfcalllconnection (process acts as both server and client)Issues: Fixed #xxx / Gap #xxx
Testing Instructions: