Add support for joins, having, whereRaw and havingRaw #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timohund
force-pushed
the
main
branch
2 times, most recently
from
537ab14
to
cd036c5
Compare
|
Hi @timohund, thanks for the PR. I am still trying to figure out why the test not running with your PR. Somehow build not passing the correct creds to access Timestream. Could you try to create PR from a different branch than your main! maybe a feature branch to see if maybe it will run test with correct creds |
|
@norbybaru Thanks for your feedback, i will open a new pr from a new branch. |
|
@norbybaru regarding the credentials. I would guess that using the credentials in a pipeline of a pr is not possible at all because then i would be able to create a pr with code that could steal the credentials. Maybe it is possible to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.