Add missing features #24
Conversation
|
@norbybaru do you see the chance that this can get merged? Regarding the integration tests, please see my comment in #20 (comment) is guess the probleme here are the credentials in the pull request context. Is there anything that can be done to get that merged? |
| @@ -6,6 +6,10 @@ | |||
|
|
|||
| final class TimestreamReaderDto extends AbstractTimestreamDto | |||
| { | |||
| private ?int $maxRows = null; | |||
There was a problem hiding this comment.
is the maxRows necessary? I still don't see how much useful this one is! can give an example for it?
My understanding is we can just rely on the nextToken. If the query should paginate then they can make use of Limit in the query to limit max results per page I think
| @@ -6,6 +6,10 @@ | |||
|
|
|||
| final class TimestreamReaderDto extends AbstractTimestreamDto | |||
| { | |||
| private ?int $maxRows = null; | |||
|
|
|||
| private string $nextTokenToContinueReading = ''; | |||
There was a problem hiding this comment.
I can't seem to find where this is being used as well!
In the loop you are always calling runQuery($params) which will have the nextToken already available in $params
This pr add's the following features: