Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do a release of 1.1.1 for libnabo
Summary:
The source release of 1.1.0 was done on this repository without bumping the package.xml version. This means that that version cannot be released on the ROS 2 buildfarm to fix https://build.ros2.org/view/Rbin_uN64/job/Rsrc_uN__libnabo__ubuntu_noble__source/ .
Instead of moving the tag or any other git shenanigans, just make a new release 1.1.1 that properly updates the CHANGELOG and bumps the package.xml. Once this is merged in, I'll need one of the maintainers to also create a tag (1.1.1), at which point we can
bloom-release
this and fix the build on the ROS 2 buildfarm.Changes and type of changes (quick overview):
Checklist:
Code related
(i.e.: function, class, script header, README.md)
(Check contributing/contributing_instructions.md for local testing procedure using libnabo-build-system)
PR creation related
base ref
branch is set to thedevelop
branch(the build-system won't be triggered otherwise)
develop
branch(the build-system will reject it otherwise)
PR description related
# <issue-id>
if changes are of typefix
(See contributing/commit_msg_reference.md for details)