Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.1 #135

Merged

Conversation

clalancette
Copy link
Contributor

Description

Do a release of 1.1.1 for libnabo

Summary:

The source release of 1.1.0 was done on this repository without bumping the package.xml version. This means that that version cannot be released on the ROS 2 buildfarm to fix https://build.ros2.org/view/Rbin_uN64/job/Rsrc_uN__libnabo__ubuntu_noble__source/ .

Instead of moving the tag or any other git shenanigans, just make a new release 1.1.1 that properly updates the CHANGELOG and bumps the package.xml. Once this is merged in, I'll need one of the maintainers to also create a tag (1.1.1), at which point we can bloom-release this and fix the build on the ROS 2 buildfarm.

Changes and type of changes (quick overview):

  • 1.1.1 release

Checklist:

Code related

  • [N/A] I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • [N/A] I have commented hard-to-understand code
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • [N/A] All tests pass locally with my changes
    (Check contributing/contributing_instructions.md for local testing procedure using libnabo-build-system)

PR creation related

  • My pull request base ref branch is set to the develop branch
    (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the develop branch
    (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix
  • I have included a high-level list of changes and their corresponding types
    (See contributing/commit_msg_reference.md for details)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@RedLeader962
Copy link
Contributor

@clalancette Thanks for flagging that. We recently took over the maintenance of libnabo and are in the process of fixing/improving several components. libnabo is a dependency for many projects both in the ros ecosystem and outside of it. Admittedly, our first focus as been solely on the non-ros release so far. We plan on deploying automated release tool very soon and I'll make sure the component that are required for the ros build farm are properly handled.

@boxanm Regarding our previous discussion on where the CHANGELOG.rst was coming from: ROS2 Releasing a Package

@RedLeader962
Copy link
Contributor

RedLeader962 commented Mar 19, 2024

@boxanm I'll take care of it, just adding you as a reviewer to keep you in the loop.

@boxanm
Copy link
Contributor

boxanm commented Mar 19, 2024

Hi @clalancette, as @RedLeader962 mentioned, we recently took over maintaining the library. In fact, until today I didn't know libnabo was present on the ROS2 build farm. In any case, thanks for the PR!

@RedLeader962 RedLeader962 merged commit c8eb78b into norlab-ulaval:master Mar 22, 2024
@clalancette clalancette deleted the clalancette/1.1.1-release branch March 22, 2024 11:56
@clalancette
Copy link
Contributor Author

Thanks for merging and tagging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants