Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install any.hpp #61

Merged
merged 2 commits into from
Apr 26, 2017
Merged

Install any.hpp #61

merged 2 commits into from
Apr 26, 2017

Conversation

HannesSommer
Copy link
Collaborator

This installs the new any.hpp into include/nabo (was missing before). One drawback is that the third-party tagging gets lost this way. Is that a problem?

@HannesSommer
Copy link
Collaborator Author

HannesSommer commented Apr 25, 2017

This is kind of urgent, because currently most dependers probably fail to build.

@stephanemagnenat
Copy link
Collaborator

One drawback is that the third-party tagging gets lost this way.

Could we imagine to install in nabo/third_party/? For the sake of simplicity, we could match that locally and move any.hpp from third_party/ to nabo/third_party/.

@HannesSommer
Copy link
Collaborator Author

Sure. I've just committed this "move". Looks cleaner to me :).

@HannesSommer
Copy link
Collaborator Author

I'm merging this to reduce the urgency (I'm pretty sure these changes only improve things). We can still patch later if it turns out not to be the final solution.

@HannesSommer HannesSommer merged commit 9c0e1c2 into master Apr 26, 2017
@HannesSommer HannesSommer deleted the fix/installAny branch October 9, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants