Return numerically maximal index (unsigned) or -1 (signed) for no match case #79
Conversation
nabo/index_heap.h
Outdated
|
|
||
|
|
||
| //! invalid index | ||
| static constexpr auto InvalidIndex = std::numeric_limits<IT>::max(); |
There was a problem hiding this comment.
Once you've converted this to a templated constexpr inline function, you could return as value :
std::is_unsigned<IT>::value ? std::numeric_limits<IT>::max() : IT(-1);
| @@ -213,7 +213,17 @@ namespace Nabo | |||
| #define NABO_VERSION "1.0.6" | |||
| //! version of the Nabo library as an int | |||
| #define NABO_VERSION_INT 10006 | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
If you make another commit, could you add a comment here, like:
// TODO (c++14) Convert invalidIndex, invalidValue to constexpr templated variables
|
Aha, I believe you've found a bug in the unit tests: But now there should probably be |
There was a problem hiding this comment.
Great, that should do.
Thanks!
@simonlynen , @stephanemagnenat , any concerns? E.g. style-wise?
| const float distDiff(fabsf((pbf-pq).squaredNorm() - (pkdtree-pq).squaredNorm())); | ||
| if (distDiff > numeric_limits<float>::epsilon()) | ||
| const T distDiff(fabsf((pbf-pq).squaredNorm() - (pkdtree-pq).squaredNorm())); | ||
| if (distDiff > numeric_limits<T>::epsilon()) |
|
I first have to find out why the tests do not pass |
|
Would be nice if you take a quick look at the test. What i have found out so far is that indexes_kdtree is filled with -1 and dists2_kdtree is filled with 0 if |
|
Okay, I'll do that. Not now but later, probably weekend. Thanks! |
|
@HannesSommer Should be fixed now ;) |
HannesSommer
changed the title
Address issue #2.