Assert template type for invalid setters #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesSommer
approved these changes
Nov 14, 2017
nabo/nabo.h
Outdated
| @@ -217,11 +217,13 @@ namespace Nabo | |||
| // TODO (c++14) Convert invalidIndex, invalidValue to constexpr templated variables. | |||
| template <typename IndexType> | |||
| inline constexpr IndexType invalidIndex() { | |||
| static_assert(std::numeric_limits<IndexType>::is_integer, ""); | |||
There was a problem hiding this comment.
Minor: I'd suggest std::is_integral instead. That is a bit more symmetric and numeric_limits is not defined for non numeric types. The error might differ for some compilers between a false value and a substitution failure. I don't know what the standard says here. Does somebody else?
There was a problem hiding this comment.
From the C++11 standard section 18.3.2.3: The default numeric_limits template shall have all members, but with 0 or false values. Still, I will change it to std::is_integral.
There was a problem hiding this comment.
Ah, thanks! I believed otherwise. Thanks for changing anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure at compile time that template parameters conform to our assumptions.