port to c++11 #89
Merged
port to c++11 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
davisking/dlib#293 fwiw |
|
ok to test |
HannesSommer
reviewed
Mar 5, 2018
tests/helpers.h
Outdated
| timer():_start_time(high_resolution_clock::now()){ } | ||
| void restart() { _start_time = high_resolution_clock::now(); } | ||
| double elapsed() const // return elapsed time in seconds | ||
| { return duration_cast<chrono::nanoseconds>(high_resolution_clock::now() - _start_time).count() / double(1000000000); } |
There was a problem hiding this comment.
It should be possible to write this more concise as
return duration_cast<duration<double>>(high_resolution_clock::now() - _start_time).count();
tests/helpers.h
Outdated
| #else // _POSIX_TIMERS | ||
| #include <boost/timer.hpp> | ||
| #endif // _POSIX_TIMERS | ||
| timer():_start_time(high_resolution_clock::now()){ } |
There was a problem hiding this comment.
I'd make high_resolution_clock::now() a private static function, e.g. curTime like before to deduplicate the three occurrences.
tests/helpers.h
Outdated
| namespace boost | ||
| #include <chrono> | ||
| using std::chrono::high_resolution_clock; | ||
| using std::chrono::duration_cast; |
There was a problem hiding this comment.
I'd rather use explicit scoping or function level using below.
|
Hi! Yeah, I actually wanted to do what you suggested, but I don't have my laptop here, so feel free to do it. Otherwise I can do it when I get home. :-) |
HannesSommer
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the mandatory boost dependency, only thing left is boost::python, which ideally would be replaced with pybind11 (helped dlib quite a bit when it did).