Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake fix on Windows #95

Merged
merged 2 commits into from
Feb 7, 2019
Merged

CMake fix on Windows #95

merged 2 commits into from
Feb 7, 2019

Conversation

simonpierredeschenes
Copy link
Contributor

@simonpierredeschenes simonpierredeschenes commented Jan 24, 2019 •
edited by HannesSommer
Loading

Addressing #92

Closes #92 .

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@HannesSommer
Copy link
Collaborator

add to whitelist

HannesSommer
HannesSommer approved these changes Feb 7, 2019
View reviewed changes
Copy link
Collaborator

@HannesSommer HannesSommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simonpierredeschenes ! LGTM :).

@HannesSommer HannesSommer merged commit 7b20c31 into norlab-ulaval:master Feb 7, 2019
@simonpierredeschenes simonpierredeschenes deleted the optional_compilation_tests branch May 9, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannesSommer HannesSommer HannesSommer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonpierredeschenes @ethzasl-jenkins @HannesSommer