Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the transformation to eigen vectors #467

Merged

Conversation

aguenette
Copy link
Member

This PR adds the eigen vectors to the descriptors that need to be transformed in the RigidTransformation and SimilarityTransformation methods, because it was not the case when they were present in the descriptors. This was causing issues when trying to visualize them and working with them.

@YoshuaNava
Copy link
Contributor

@aguenette The PR looks good to me. Nonetheless, I wanted to ask if it would be possible to create in a follow-up a centralized definition of commonly used point cloud fields. For example, normals, eigVectors, densities, etc? Such that any user of these fields can fetch the definitions from there.

@aguenette
Copy link
Member Author

@aguenette The PR looks good to me. Nonetheless, I wanted to ask if it would be possible to create in a follow-up a centralized definition of commonly used point cloud fields. For example, normals, eigVectors, densities, etc? Such that any user of these fields can fetch the definitions from there.

Hi @YoshuaNava! Thanks for your review. About the centralized definition of the point cloud fields, the DataPointsFilters page already provide a short definition of the different fields present in the filters, but some filters miss some fields. So, it could be a good start to add the missing ones and improve their definitions or maybe we could add a section at the end of the DataPointsFilters page who would provide a more detailed definition of them. What do you think? Were you talking about something like this?

@pomerlef pomerlef merged commit 2ddeb64 into norlab-ulaval:master Jul 6, 2021
@aguenette aguenette deleted the fix/eigenvectors_transformation branch July 6, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants