Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving this draft here before I have time to finish it. Related links:
https://cliutils.gitlab.io/modern-cmake/chapters/packages/OpenMP.html
https://gist.github.com/scivision/16c2ca1dc250f54d34f1a1a35596f4a0
https://cmake.org/cmake/help/latest/module/FindOpenMP.html
https://gitlab.kitware.com/cmake/cmake/-/issues/24097
Note
This change requires 3.12.0 as a minimum CMake version.
Since Ubuntu 18.04 natively ships with CMake v3.10.2, this PR breaks an easy compilation on Bionic, although more recent CMake can be installed, just not with
apt
.Description
Summary:
Changes and type of changes (quick overview):
Checklist:
Code related
(i.e.: function, class, script header, README.md)
(Check README.md #Contributing
for local testing procedure using libpointmatcher-build-system)
PR creation related
base ref
branch is set to thedevelop
branch(the build-system won't be triggered otherwise)
develop
branch(the build-system will reject it otherwise)
PR description related
# <issue-id>
if changes are of typefix
feat
fix
docs
style
refactor
perf
test
build
ci
chore
revert
<type>!
see commit_msg_reference.md
in the repository root for details
Note for repository admins
Release PR related
push/merge
on the default branch (ie:master
)and the
release
branch.draft
mode until all the release reviewers are ready to push the release.release
->master
branch is created (not in draft mode),