-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.4.2 prep #562
Release 1.4.2 prep #562
Conversation
…ry` [NMO-442] - move contributing instructions to a contributing_instructions.md file - move commit_msg_reference.md to `doc/contributing directory` - change remaining ethz-asl domain reference to norlab-ulaval - main `README.MD` - move the summary up, under the top banner - add missing installer script instructions - add docker image usage instructions
…boost.io - see [boost issue #6775](triton-inference-server/server#6775)
- Also muted the generate doc flag until UseDoxygen.cmake line 112 is fixed
…e badges and add teamcity url to badge
…ease-logic-NMO-469 Add dockerhub release logic and improve main readme
…nsformation compute functions.
Update .gitingore with auto-generated patterns for C++, Python, JetBrains IDEs ,and VSCode
- update build matrix - update supported version in main doc, ubuntu install doc and contributing instructions - update submodule to latest - update jetbrains local run configuration
…b-icp-mapper [NMO-508] Problem: It was crashing the build under ubuntu jammy
…-to-build-matrix-NMO-508 build: add ubuntu jammy to the repository suported version
…pointmatcher into orientation_descriptor
…ation_unit_tests fix: Change unit tests floating point type to double and add a precision argument to output streams
Update the minimum required Cmake version to 3.10.2
…ests-failing-on-some-platforms fix: Issue 534 transformation tests failing on some platforms
# Conflicts: # utest/ui/Transformations.cpp
…ory3D for rotations to 1e-6
# Conflicts: # package.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great job!
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple places where the repo version is set to 1.4.0
. Is it correct?
Yes those are doc or test related. The doc ones are for example like fetching a previous release. The test one could point to any existing release. We won't increment those at each release. Also I'm going to deploy semantic-release workflow for the next release so that version increments in files be automated. We won't waist time with this anymore and its not error-prone contrary to doing it manually. |
@boxanm By the way if its ok with you, I recommend we discard the Sonarcloud Quality Gate failure (Duplication of new code). At this moment Sonarcloud purpose for us is for providing code insight, not as rule. We will comeback to that issue eventually. |
Summary:
Checklist:
Code related
(i.e.: function, class, script header, README.md)
(Check README.md #Contributing
for local testing procedure using libpointmatcher-build-system)
PR description related
# <issue-id>
if changes are of typefix
Note for repository admins
Release PR related
push/merge
on the default branch (ie:master
)and the
release
branch.