feat: support CRUD on TrustPolicy #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
force-pushed
the
support-policy-crud
branch
from
0de764a
to
a134244
Compare
binbin-li
changed the title
chloeyin
reviewed
Sep 14, 2022
chloeyin
reviewed
Sep 14, 2022
chloeyin
reviewed
Sep 14, 2022
chloeyin
reviewed
Sep 14, 2022
binbin-li
force-pushed
the
support-policy-crud
branch
from
a134244
to
82826c6
Compare
chloeyin
reviewed
Sep 14, 2022
chloeyin
reviewed
Sep 14, 2022
binbin-li
force-pushed
the
support-policy-crud
branch
from
82826c6
to
7773651
Compare
JeyJeyGao
reviewed
Sep 15, 2022
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
binbin-li
force-pushed
the
support-policy-crud
branch
from
49dc778
to
80bfeb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Defined and implemented functions to support CRUD on the policy file.
This PR just adds the basic support. We'll need another PR to refactor it to integrate with the current config read/write module.
Test?
Did manually tests with PR: notaryproject/notation#333. Will add unit tests in another PR.
Signed-off-by: Binbin Li libinbin@microsoft.com