feat: add policy command #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
force-pushed
the
support-policy
branch
from
ffa425a
to
1e69d59
Compare
binbin-li
force-pushed
the
support-policy
branch
from
1e69d59
to
1954a28
Compare
binbin-li
force-pushed
the
support-policy
branch
2 times, most recently
from
3044065
to
348a110
Compare
Codecov Report
@@ Coverage Diff @@
## dev-rc.1 #333 +/- ##
============================================
+ Coverage 31.15% 31.82% +0.67%
============================================
Files 26 27 +1
Lines 1711 1986 +275
============================================
+ Hits 533 632 +99
- Misses 1161 1332 +171
- Partials 17 22 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
binbin-li
force-pushed
the
support-policy
branch
4 times, most recently
from
82aed08
to
d2bcec7
Compare
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
|
Now that notaryproject/notation-go#132 is merged, does this make sense to try to PR to main and kick off a review from everyone else? |
Signed-off-by: Binbin Li <libinbin@microsoft.com>
binbin-li
force-pushed
the
support-policy
branch
from
d2bcec7
to
e41bb47
Compare
Once we fully test the dev-rc.1 branch, we can make the PR to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add policy commands. It supports adding/updating/reading/deleting policies.
Spec can be found in https://hackmd.io/AP9Xz9AbRpOy6ASpbok23A?view#Manage-Trust-Policy.
Test
Manually tested commands. Test cases can be checked in: https://hackmd.io/@H7a8_rG4SuaKwzu4NLT-9Q/S1j2Yspxj
Notes
This PR depends on notaryproject/notation-go#132, so the build will fail until it's merged.
Signed-off-by: Binbin Li libinbin@microsoft.com