Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dir package allows user to define user/system write level #134

Merged
merged 2 commits into from
Sep 13, 2022
Merged

feat: dir package allows user to define user/system write level #134

merged 2 commits into from
Sep 13, 2022

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Sep 9, 2022 •
edited
Loading

  1. config add EnvelopeType argument
  2. dir package optimize: allow user define WriteLevel = UserLevel | SystemLevel
  3. add ConfigForWrite(), TrustStoreForWrite(), TrustPolicyForWrite() func to get writable path
  4. refector config pacakge: receive a path argument when load and save file to allow user to overwrite the default directory structure

@JeyJeyGao
config add envelope type argument
94406eb 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao changed the title feat: dir package allows user to define write path level feat: dir package allows user to define user/system write level Sep 9, 2022
patrickzheng200
patrickzheng200 reviewed Sep 13, 2022
View reviewed changes
dir/path.go Outdated Show resolved Hide resolved
dir/path.go Outdated Show resolved Hide resolved
dir/path.go Outdated Show resolved Hide resolved
dir/path.go Outdated Show resolved Hide resolved
dir/path.go Outdated Show resolved Hide resolved
@JeyJeyGao JeyJeyGao force-pushed the junjiegao/rc1.dev branch 2 times, most recently from 057caa1 to bad85da Compare September 13, 2022 05:39
@JeyJeyGao
feat: dir package allows user to define write path level
a209655 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
patrickzheng200
patrickzheng200 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickzheng200 patrickzheng200 merged commit accfc98 into notaryproject:dev-rc.1 Sep 13, 2022
@chloeyin chloeyin mentioned this pull request Sep 14, 2022
Merged
kody-kimberl added a commit to kody-kimberl/notation-go that referenced this pull request Mar 29, 2023
@kody-kimberl
updating to reflect new changes in notation-core-go PR notaryproject#134
5eb8697 


Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
kody-kimberl added a commit to kody-kimberl/notation-go that referenced this pull request Mar 30, 2023
@kody-kimberl
updating to reflect new changes in notation-core-go PR notaryproject#134
e6275da 


Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
kody-kimberl added a commit to kody-kimberl/notation-go that referenced this pull request Apr 20, 2023
@kody-kimberl
Updated notation-core-go dependency now that notaryproject#134 is merged
cc04997 
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickzheng200 patrickzheng200 patrickzheng200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeyJeyGao @patrickzheng200