Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding OCSP revocation checks to Verify #295

Merged
merged 32 commits into from
Apr 20, 2023
Merged

feat: adding OCSP revocation checks to Verify #295

merged 32 commits into from
Apr 20, 2023

Commits on Mar 29, 2023

  1. Adding revocation to Verify using notation-core-go implementation 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    45e4f33 View commit details
    Browse the repository at this point in the history

  2. Refactoring verifyRevocation and changing timeout to failing 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    1da5cdc View commit details
    Browse the repository at this point in the history

  3. updating to reflect new changes in notation-core-go PR notaryproject#134 

    

Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    5eb8697 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. updating to reflect new changes in notation-core-go PR notaryproject#134 

    

Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    e6275da View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. updating to reflect new naming in notation-core-go 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    fcf4050 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. refactoring constructor with revocation client 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    62276d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Updating to keep in-sync with changes to notation-core-go 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    b46ba1d View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Updating again to keep in-sync with changes to notation-core-go 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    d0594e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Addressing new PR comments 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    0ac4a13 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Updating to reflect addition of the revocation/base package in notati… 

    …on-core-go

Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    516f187 View commit details
    Browse the repository at this point in the history

  2. Incorporating NonRevokable Result and refactoring constructors 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    72490db View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Updating to align with result name change in core-go 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    83ec701 View commit details
    Browse the repository at this point in the history

  2. Updating error messages and return of Validate 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    fee006c View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Updating package name for revocation/base to revocation/result 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    c3da558 View commit details
    Browse the repository at this point in the history

  2. Adjusted logic for checking results and added server to debug logs 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    8769ae7 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Addressing new PR comments 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b71d94f View commit details
    Browse the repository at this point in the history

  2. Adding test and fix for bug with specific results 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9b39737 View commit details
    Browse the repository at this point in the history

  3. Added break and new test 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    2406b04 View commit details
    Browse the repository at this point in the history

  4. Changed revocationClient type and loop logic 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    5eee868 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Adjusting for invalidityDate change in notation-core-go 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    e150ce1 View commit details
    Browse the repository at this point in the history

  2. Addressing comments 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    206d21b View commit details
    Browse the repository at this point in the history

  3. Adding VerifierOptions 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    477691c View commit details
    Browse the repository at this point in the history

  4. Implementing GetAuthenticSigningTime 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    6556b33 View commit details
    Browse the repository at this point in the history

  5. Updating tests 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    92693c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Merge branch 'main' into main 

    Signed-off-by: Kody Kimberl <59657721+kody-kimberl@users.noreply.github.com>
    @kody-kimberl
    kody-kimberl authored Apr 19, 2023
    Configuration menu
    Copy the full SHA
    62b753f View commit details
    Browse the repository at this point in the history

  2. Updated naming 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7da3157 View commit details
    Browse the repository at this point in the history

  3. Updated to reflect change to GetAuthenticSigningTime error message 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    72888b1 View commit details
    Browse the repository at this point in the history

  4. Updated to change wording of OK debug log 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    d2a8f85 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Changed GetAuthenticSigningTime to AuthenticSigningTime 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3786bad View commit details
    Browse the repository at this point in the history

  2. Updated notation-core-go dependency now that notaryproject#134 is merged 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    cc04997 View commit details
    Browse the repository at this point in the history

  3. Addressing newest PR comments 

    Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
    @kody-kimberl
    kody-kimberl committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    dfccf1f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into main

    @kody-kimberl
    kody-kimberl authored Apr 20, 2023
    Configuration menu
    Copy the full SHA
    bbfdf3d View commit details
    Browse the repository at this point in the history