refactor: refactor registry interface #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
force-pushed
the
refactor-registry-interface
branch
from
2c45b72
to
e355c40
Compare
binbin-li
commented
Jun 24, 2022
binbin-li
force-pushed
the
refactor-registry-interface
branch
from
e355c40
to
e391237
Compare
shizhMSFT
reviewed
Jun 24, 2022
|
We also need an interface to resolve manifest descriptors from tag or digest. We may need type Repository interface{
SignatureRepository
Resolve(ctx context.Context, reference string) (notation.Descriptor, error)
} |
binbin-li
force-pushed
the
refactor-registry-interface
branch
3 times, most recently
from
08bac84
to
17f82a5
Compare
binbin-li
changed the title
rgnote
reviewed
Jun 24, 2022
binbin-li
force-pushed
the
refactor-registry-interface
branch
from
17f82a5
to
e9afd84
Compare
rgnote
reviewed
Jun 27, 2022
rgnote
reviewed
Jun 27, 2022
binbin-li
force-pushed
the
refactor-registry-interface
branch
from
e9afd84
to
f27ff50
Compare
rgnote
approved these changes
Jun 27, 2022
shizhMSFT
reviewed
Jun 27, 2022
Signed-off-by: Binbin Li <libinbin@microsoft.com>
binbin-li
force-pushed
the
refactor-registry-interface
branch
from
f27ff50
to
940d626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
LookupAPI to support returningannotationsfor signature verficiation as well.PutAPI to do the job linking manifest and signature and upload the registry.Signed-off-by: Binbin Li libinbin@microsoft.com