Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Multipart scanning UX #426

Closed
Tbaut opened this issue Oct 21, 2019 · 1 comment · Fixed by #428
Closed

Enhance Multipart scanning UX #426

Tbaut opened this issue Oct 21, 2019 · 1 comment · Fixed by #428
Assignees
@pmespresso
Milestone
v4.1 Add network ...

Comments

@Tbaut
Copy link
Contributor

Tbaut commented Oct 21, 2019

When I scan a big multipart QR code my phone might miss some of the codes.
If I scan say a 10 parts code, I miss the 10th:

  • I have no idea that I missed it if I don't carefully keep track of the QR codes changes and the number being iterated
  • I have no idea which one I missed, and I'll need to remain steady for another full round of QR hoping not to miss it another time
  • I have to wait (at least) one other full round (this is on the code generation part)

TL;DR
I'd be nice to know if we missed a QR code, and get some visualization of where we are in the scanning process represented by boxes white (not yet scanned), green (scanned successfully) or red (missed) e.g:
. . ✅ ✅ 🛑 ✅ . . .
@pmespresso
Copy link
Contributor

#320 related

@pmespresso pmespresso self-assigned this Oct 21, 2019
This was referenced Oct 21, 2019
Merged
Closed
pmespresso added a commit that referenced this issue Oct 30, 2019
@pmespresso
fix: #426 (Payload Details When Signing Hash), #427 (Multipart Missed…
5c587fd 
… Frames) (#428)

* fix: show prehash image along with hash

* fix: lint

* fix: display missed frames by index

* fix: remove from missed frames list once scanned

* fix: edge case for multiple  loops

* fix: multiple loops

* fix: off by one error

* fix: asyn cscanner state clear

* chore: bump @polkadot-js deps

* fix: make tests pass

* fix: qrcodehash

* fix: blake2s -> blake2b

* fix: signing hash

* fix: hash the correct thing ffs

* fix: stray print

* fix: show payload details along with hash

* fix: stray logs

* fix: minor grumble

* make android able to sign single part

* fix: ethereum sign msg

* fix: ethereum sign msg

* fix: undeifned

* fix: prehash optional
pmespresso added a commit that referenced this issue Nov 9, 2019
@pmespresso
fix: #426 (Payload Details When Signing Hash), #427 (Multipart Missed…
547040d 
… Frames) (#428)

* fix: show prehash image along with hash

* fix: lint

* fix: display missed frames by index

* fix: remove from missed frames list once scanned

* fix: edge case for multiple  loops

* fix: multiple loops

* fix: off by one error

* fix: asyn cscanner state clear

* chore: bump @polkadot-js deps

* fix: make tests pass

* fix: qrcodehash

* fix: blake2s -> blake2b

* fix: signing hash

* fix: hash the correct thing ffs

* fix: stray print

* fix: show payload details along with hash

* fix: stray logs

* fix: minor grumble

* make android able to sign single part

* fix: ethereum sign msg

* fix: ethereum sign msg

* fix: undeifned

* fix: prehash optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmespresso pmespresso

Labels
None yet
Projects
None yet
Milestone
v4.1 Add network / metadata with QR s...
3 participants
@pmespresso @Tbaut and others