setCode is showed as a Message signing #427
Assignees
Milestone
Comments
This was referenced Oct 21, 2019
pmespresso
added a commit
that referenced
this issue
Oct 30, 2019
… Frames) (#428) * fix: show prehash image along with hash * fix: lint * fix: display missed frames by index * fix: remove from missed frames list once scanned * fix: edge case for multiple loops * fix: multiple loops * fix: off by one error * fix: asyn cscanner state clear * chore: bump @polkadot-js deps * fix: make tests pass * fix: qrcodehash * fix: blake2s -> blake2b * fix: signing hash * fix: hash the correct thing ffs * fix: stray print * fix: show payload details along with hash * fix: stray logs * fix: minor grumble * make android able to sign single part * fix: ethereum sign msg * fix: ethereum sign msg * fix: undeifned * fix: prehash optional
pmespresso
added a commit
that referenced
this issue
Nov 9, 2019
… Frames) (#428) * fix: show prehash image along with hash * fix: lint * fix: display missed frames by index * fix: remove from missed frames list once scanned * fix: edge case for multiple loops * fix: multiple loops * fix: off by one error * fix: asyn cscanner state clear * chore: bump @polkadot-js deps * fix: make tests pass * fix: qrcodehash * fix: blake2s -> blake2b * fix: signing hash * fix: hash the correct thing ffs * fix: stray print * fix: show payload details along with hash * fix: stray logs * fix: minor grumble * make android able to sign single part * fix: ethereum sign msg * fix: ethereum sign msg * fix: undeifned * fix: prehash optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When scanning a multipart QR code for e.g
system>setCodein apps, Signer shows to the user a hash to sign and doesn't give any hint regarding the method that we call.We should instead show the usual Tx details view, but with a truncated payload e.g:
You will sign the transaction calling the method setCode with the following arguments:
code: "0x87EF...BEEF"
The text was updated successfully, but these errors were encountered: