Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust bindings refactoring and bip39_mnemonic impl #194

Closed
wants to merge 7 commits into from
Closed

Rust bindings refactoring and bip39_mnemonic impl #194

wants to merge 7 commits into from

Conversation

lexfrl
Copy link
Contributor

@lexfrl lexfrl commented Nov 29, 2018 •
edited
Loading

there is a problem with a Java build

@lexfrl lexfrl changed the title [WIP] Substrate support Rust bindings refactoring Dec 18, 2018
@lexfrl lexfrl changed the title Rust bindings refactoring Rust bindings refactoring and bip39_mnemonic Dec 18, 2018
@lexfrl lexfrl changed the title Rust bindings refactoring and bip39_mnemonic Rust bindings refactoring and bip39_mnemonic impl Dec 18, 2018
@lexfrl lexfrl requested a review from debris December 18, 2018 10:24
lexfrl
lexfrl commented Dec 18, 2018
View reviewed changes
rust/signer/src/android.rs
}
}

unsafe fn test_vm() -> TestVM {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not work ATM

@lexfrl
Copy link
Contributor Author

lexfrl commented Jan 23, 2019

Can be merged.
The UI impl. for bip39 mnemonic will be delivered as a separate PR.

@lexfrl lexfrl mentioned this pull request Feb 12, 2019
Closed
@lexfrl
Copy link
Contributor Author

lexfrl commented Feb 14, 2019 •
edited
Loading

It's worth to mention that it would be much smoother to make changes to lib.rs on top the actual (#194) PR.

@lexfrl lexfrl mentioned this pull request Mar 30, 2019
Merged
@maciejhirsz
Copy link
Contributor

Closing in favor of #234.

@maciejhirsz maciejhirsz closed this Apr 2, 2019
@Tbaut Tbaut deleted the substrate branch September 17, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debris debris Awaiting requested review from debris

@maciejhirsz maciejhirsz Awaiting requested review from maciejhirsz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lexfrl @maciejhirsz @Tbaut