-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring bindings #234
Refactoring bindings #234
Conversation
Show seed type and green field if valid bip39
@maciejhirsz is this ready for testing on iOS? |
@yjkimjunior yes please! :) |
@maciejhirsz the build is failing for me because signer uses an older version of Swift than Xcode10.2 supports. Should this be updated, or should I just go downgrade my Xcode? |
If we can upgrade it I think we should. I think most (all?) of our swift code is internally using just objective C, so there shouldn't be any breakage, but in case there is feel free to ping me on Riot. |
…nto mh-clean-up-bindings
compiles and no more memory allocation errors, able to create and restore accounts, however, I am able to delete it after i type in just 4 out of 6 of my pin digits. http://g.recordit.co/C7maeWWAWi.gif |
Also I see on your recording that the qr code doesn't load and remains white, right? |
Ah yes, that too. |
So everything compiles at last, and the QR code is showing. Need to figure out what's up with account deletion though. |
leaving this here reference http://g.recordit.co/co1sYl9LrF.gif |
I've touched this logic last here: https://github.com/paritytech/parity-signer/pull/195/files#diff-ed7c745a0e11d1facbcbeca7e4a54c0aL46 and it might not have been tested enough on iphone |
JS looks fine, just a bit convoluted. It might be possible that errors aren't propagated properly for iOS on this branch, which is what we use to check if the pin is correct. I'll dig deeper tomorrow to see if I can either figure this out or at least mock something to confirm or reject the hypothesis I have now. |
@maciejhirsz works well for me! |
This PR abstracts out bindings in a way that makes iOS and Android extern functions DRY. Type conversion and error handling (throwing exceptions in Java) is done automagically via the
export!
macro. This also removes a whole bunch ofunwrap
andexpects
smell.It also adds native function for generating QR codes in Rust, fixes #219.
Make Android useKeyPair
pointers similar to how iOS was done before.