Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VMA usage and update APIs to reflect the simplification. #588

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

RubyNova
Copy link
Member

@RubyNova RubyNova commented Jul 2, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This change will be a major rework of important graphics concepts.

Is there an open issue that this resolves? If so, please link it here.
No.

What is the current behavior? (You can also link to an open issue here)
the legacy API exists and makes everyone cry. Especially me.

What is the new behavior (if this is a feature change)?
The new API and VMA support will make less people cry. Particularly me, benevolent rendering madman Matt. (Nananananananananana Mattman!)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes. RIP Anything that's predefined ECS based for a little bit in interop.

Other information:
This PR was sponsored by Padme's very dubious choice in a life partner.

@RubyNova RubyNova added feature A feature ticket for the NovelRT. engine core Tickets pertaining to the engine core codebase. engine api Tickets pertaining to NovelRT's end-user API. labels Jul 2, 2023
@RubyNova RubyNova requested a review from FiniteReality as a code owner July 2, 2023 02:48
@FiniteReality
Copy link
Contributor

👨 👩 🧒 🧒 🧒 🧒 💀

@RubyNova RubyNova marked this pull request as draft July 2, 2023 02:50
@FiniteReality FiniteReality mentioned this pull request Jul 2, 2023
3 tasks
@FiniteReality
Copy link
Contributor

Related: #583

@RubyNova RubyNova added this to the Project Sam - MVP (v1.0.0) milestone Jul 2, 2023
@FiniteReality FiniteReality mentioned this pull request Jul 2, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine api Tickets pertaining to NovelRT's end-user API. engine core Tickets pertaining to the engine core codebase. feature A feature ticket for the NovelRT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants