Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Audio to new header format #589

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Move Audio to new header format #589

merged 2 commits into from
Jul 2, 2023

Conversation

capnkenny
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Moves the Audio namespace into the expected header format.

Is there an open issue that this resolves? If so, please link it here.
Nope.

What is the current behavior? (You can also link to an open issue here)
The same as before.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Need to link to NovelRT-Audio

Other information:
Meeehhhhhhhhh

@FiniteReality
Copy link
Contributor

My eyes are open and waiting for sound waves

@FiniteReality
Copy link
Contributor

Related: #588 #583

Copy link
Member

@RubyNova RubyNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RubyNova RubyNova enabled auto-merge July 2, 2023 03:14
@RubyNova RubyNova merged commit 8cf5352 into main Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants