This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Gradle upgrade hint #116
Merged
Gradle upgrade hint #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins review this PR? |
tasomaniac
reviewed
Apr 14, 2017
| // detected Gradle 3.3 or smaller | ||
| // show message for required gradle upgrade | ||
| // details: https://github.com/novoda/bintray-release/issues/112 | ||
| System.err.println(""" |
There was a problem hiding this comment.
I'm not 100% sure but if we know that it will going ti fail anyways. Instead of printing, we can also do throw new GradleException with this message?
There was a problem hiding this comment.
The problem with failing in configuration phase is that you can't even upgrade with ./gradlew wrapper --gradle-version 3.5 because it will fail, too.
There was a problem hiding this comment.
Upgrade not possible with GradleException
Pascals-MBP:android-base pascalwelsch$ ./gradlew wrapper --gradle-version 3.5 --distribution-type allThe JavaCompile.setDependencyCacheDir() method has been deprecated and is scheduled to be removed in Gradle 4.0.
Incremental java compilation is an incubating feature.
The TaskInputs.source(Object) method has been deprecated and is scheduled to be removed in Gradle 4.0. Please use TaskInputs.file(Object).skipWhenEmpty() instead.
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring project ':library'.
>
**************************************
WARNING: Gradle 3.3 not supported by bintray-release plugin. Update required!
The bintray-release plugin doesn't support version of Gradle below 3.4 for Android libraries. Please upgrade to Gradle 3.4 or later.
The last bintray-release plugin supporting Gradle 3.3 is 'com.novoda:bintray-release:4.0'
Upgrade Gradle:
./gradlew wrapper --gradle-version 3.5 --distribution-type all
The bintray-release plugin can't create a Publication for your Android Library with Gradle 3.3!
**************************************
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 0.655 secs
There was a problem hiding this comment.
Haha 😂 never thought about that. Very true.
tasomaniac
approved these changes
Apr 14, 2017
|
@hal9002 ok to test |
|
Anything left which prevent to merge it? 🤔 |
|
@StefMa I was waiting for another review maybe. But I think it is simple enough. Let's 🚢 it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on top of #115
Adds a warning when this plugin will be used with an unsupported Gradle version instead of a hard crash.
Example with Gradle 3.3:
Before
Now
./gradlew cleanworks without error but prints message./gradlew clean bundleRelease bintrayUploadprints message but can't publish a release