Correcting isntall #1274
Closed
Correcting isntall #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
May 12, 2020
| @@ -28,9 +28,8 @@ var affordances = { | |||
| 'verison': 'version', | |||
| 'ic': 'ci', | |||
| 'innit': 'init', | |||
| 'isntall': 'install', | |||
| 'install': 'install', | |||
There was a problem hiding this comment.
this is very much not a typo; it's an attempt for npm to fix a user's typo.
ljharb
reviewed
May 12, 2020
| @@ -92,7 +92,7 @@ | |||
| var commandCache = {} | |||
| var aliasNames = Object.keys(aliases) | |||
|
|
|||
| var littleGuys = [ 'isntall', 'verison' ] | |||
| var littleGuys = [ 'install', 'verison' ] | |||
There was a problem hiding this comment.
you missed "verison" which is a misspelling of "version" - but these are also intentional.
these little guys? i wouldn't worry about these little guys.
|
thanks @ljharb and @tomazcunha 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correcting a typo for the install command
When using the command 'npm install --help', I noticed that in the description 'aliases: i, isntall, add', install is written isntall. I imagine that this is some type of typo, so looking at the code, I made some changes that I believe can help. Thank you.