Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting isntall #1274

Closed
wants to merge 2 commits into from
Closed

Correcting isntall #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
597caba
Altered isntall to install.
tomazcunha May 12, 2020
3797d68
Removing repeated 'isntall-clean': 'ci'.
tomazcunha May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/config/cmd-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ var affordances = {
'verison': 'version',
'ic': 'ci',
'innit': 'init',
'isntall': 'install',
'install': 'install',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very much not a typo; it's an attempt for npm to fix a user's typo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks for the answer.

'install-clean': 'ci',
'isntall-clean': 'ci',
'dist-tags': 'dist-tag',
'apihelp': 'help',
'find-dupes': 'dedupe',
Expand Down
2 changes: 1 addition & 1 deletion lib/npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
var commandCache = {}
var aliasNames = Object.keys(aliases)

var littleGuys = [ 'isntall', 'verison' ]
var littleGuys = [ 'install', 'verison' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you missed "verison" which is a misspelling of "version" - but these are also intentional.

these little guys? i wouldn't worry about these little guys.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks for the answer.

var fullList = cmdList.concat(aliasNames).filter(function (c) {
return plumbing.indexOf(c) === -1
})
Expand Down