Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update package.json docs to include repository.directory details #140

Merged
merged 1 commit into from
Jan 29, 2019
Merged

doc: update package.json docs to include repository.directory details #140

merged 1 commit into from
Jan 29, 2019

Conversation

greysteil
Copy link
Contributor

Implementation of npm/rfcs#19.

@greysteil greysteil requested a review from a team as a code owner January 18, 2019 11:24
@felixfbecker
Copy link

Looks like this needs a rebase

@felixfbecker felixfbecker mentioned this pull request Jan 21, 2019
Merged
@greysteil
Copy link
Contributor Author

Yes it does! Done.

styfle
styfle reviewed Jan 21, 2019
View reviewed changes
doc/files/package.json.md Outdated Show resolved Hide resolved
@aeschright aeschright added docs semver:minor new backwards-compatible feature labels Jan 22, 2019
@greysteil greysteil mentioned this pull request Jan 25, 2019
Closed
@zkat zkat removed the semver:minor new backwards-compatible feature label Jan 28, 2019
felixfbecker
felixfbecker approved these changes Jan 29, 2019
View reviewed changes
Copy link

@felixfbecker felixfbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

styfle
styfle approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@greysteil
Copy link
Contributor Author

@aeschright - updated! Hopefully this is good to go now. 🙏

@aeschright aeschright changed the base branch from latest to release-next January 29, 2019 23:49
@aeschright aeschright merged commit 3663cde into npm:release-next Jan 29, 2019
aeschright pushed a commit that referenced this pull request Feb 14, 2019
@greysteil @aeschright
doc: update package.json docs to include repository.directory details (…
aa32239 
…#140)

PR-URL: #140

Credit: @greysteil
Reviewed-By: @aeschright
@greysteil greysteil deleted the add-directory-details-to-repository branch February 17, 2019 20:47
This was referenced Feb 18, 2019
Merged
Closed
@ybiquitous ybiquitous mentioned this pull request Feb 18, 2019
Closed
@greysteil greysteil mentioned this pull request Feb 19, 2019
Merged
@aeschright aeschright mentioned this pull request Feb 19, 2019
Closed
4 tasks
@styfle styfle mentioned this pull request Feb 25, 2019
Merged
mikemimik pushed a commit that referenced this pull request Dec 2, 2019
@ybiquitous
feat: npm repo support repository.directory field
980200b 
See #140

PR-URL: #163
Credit: @ybiquitous
Close: #163
Reviewed-by: @mikemimik
isaacs pushed a commit that referenced this pull request Aug 4, 2020
@ybiquitous @isaacs
feat: npm repo support repository.directory field
ebf7ac9 
Related: #140

PR-URL: #163
Credit: @ybiquitous
Close: #163
Reviewd-By: @isaacs
@kevinjm39 kevinjm39 mentioned this pull request May 1, 2022
Open
@kevinjm39 kevinjm39 mentioned this pull request May 1, 2022
Open
@kevinjm39 kevinjm39 mentioned this pull request Nov 30, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Nov 30, 2023
Open
@varmakarthik12 varmakarthik12 mentioned this pull request Nov 30, 2023
Open
@bumplzz69 bumplzz69 mentioned this pull request Nov 30, 2023
Open
@mtdev2 mtdev2 mentioned this pull request Nov 30, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Nov 30, 2023
Open
@baby636 baby636 mentioned this pull request Dec 1, 2023
Open
@kevinjm39 kevinjm39 mentioned this pull request Dec 19, 2023
Open
@MrBrain295 MrBrain295 mentioned this pull request Dec 19, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeschright aeschright aeschright left review comments

@styfle styfle styfle approved these changes

@felixfbecker felixfbecker felixfbecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@greysteil @felixfbecker @aeschright @styfle @zkat