Add directory attribute to repositories in package.json files #5643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greysteil
requested review from
aaronmcadam,
alexandrebodin,
alterx,
dangreenisrael,
danielduan,
Gongreg,
Hypnosphi,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
naipath,
ndelangen,
renaudtertrais,
rmevans9,
saponifi3d,
shilman,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
|
That's a lot of code owners! Sorry for all the notifications. @Hypnosphi - as a user of Dependabot you're probably best placed to review this. Should be an uncontroversial one. |
alexandrebodin
removed request for
Hypnosphi,
naipath,
igor-dv,
z4o4z,
rmevans9 and
usulpro
ndelangen
approved these changes
Feb 20, 2019
Codecov Report
@@ Coverage Diff @@
## next #5643 +/- ##
=======================================
Coverage 33.25% 33.25%
=======================================
Files 648 648
Lines 9325 9325
Branches 1349 1325 -24
=======================================
Hits 3101 3101
Misses 5609 5609
Partials 615 615Continue to review full report at Codecov.
|
|
Thanks @greysteil ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: it's hard for automated tools (or humans) to find the relevant packages within a monorepo.
What I did
I worked with the npm team to add a standard for declaring the directory within a repository that a package lives in. The accepted RFC is here, and the new guidance was accepted into npm's docs here.
This PR adds the recommended
directoryattribute to the repository specification for each of storybook's packages. It will allow tools like Dependabot to show only the commits that are relevant to a particular packages when creating PRs.How to test
Not required.