net: http_client: Fix payload issue on HTTP upload #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
Bug fix and improved `payload` handling in `http_client_req`. Changes to `http_client_req` behaviour: If the user provides `payload_len` it is used to generate the `Content-Length` header. This is done even if `payload_cb` is used to provide the actual data. If no `payload_len` is specified then no `Content-Length` is generated. If `payload_cb` is provided it is called to send the payload data. Otherwise `payload` is used as the payload buffer and sent. If `payload_len` is not zero, it is used as the size of `payload`. Otherwise `payload` is assumed to be a string and `strlen` is used to determine its size. This is to maintain current behaviour and not break existing samples. Signed-off-by: Arvin Farahmand <arvinf@ip-logix.com>
|
@arvinf We typically pull upstream fixes during upmerges to avoid confusion during the merge. The next upmerge should take place shortly. |
|
DNM until Upmerge #296 will be merged |
mbolivar-nordic
force-pushed
the
master
branch
2 times, most recently
from
381e998 to
a512e75
Compare
|
This got merged with upmerge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of a bug fix in the Zephyr HTTP client that causes request payloads to fail (relevant issue). The changes have already been approved for merge in the main Zephyr repo (see PR).
I am submitting this backport to be merged early, instead of the next Zephyr release, because the bug cripples upload functionality in the HTTP client for binary payloads and should be resolved as soon as possible for nRF SDK users.