http_client assumes request payload is non-binary #24431
Labels
area: Networking
bug
The issue is a bug, or the PR is fixing a bug
priority: medium
Medium impact/importance bug
Comments
jukkar
pushed a commit
that referenced
this issue
Apr 20, 2020
Bug fix and improved `payload` handling in `http_client_req`. Changes to `http_client_req` behaviour: If the user provides `payload_len` it is used to generate the `Content-Length` header. This is done even if `payload_cb` is used to provide the actual data. If no `payload_len` is specified then no `Content-Length` is generated. If `payload_cb` is provided it is called to send the payload data. Otherwise `payload` is used as the payload buffer and sent. If `payload_len` is not zero, it is used as the size of `payload`. Otherwise `payload` is assumed to be a string and `strlen` is used to determine its size. This is to maintain current behaviour and not break existing samples. Fixes #24431 Signed-off-by: Arvin Farahmand <arvinf@ip-logix.com>
hakehuang
pushed a commit
to hakehuang/zephyr
that referenced
this issue
Jun 20, 2020
Bug fix and improved `payload` handling in `http_client_req`. Changes to `http_client_req` behaviour: If the user provides `payload_len` it is used to generate the `Content-Length` header. This is done even if `payload_cb` is used to provide the actual data. If no `payload_len` is specified then no `Content-Length` is generated. If `payload_cb` is provided it is called to send the payload data. Otherwise `payload` is used as the payload buffer and sent. If `payload_len` is not zero, it is used as the size of `payload`. Otherwise `payload` is assumed to be a string and `strlen` is used to determine its size. This is to maintain current behaviour and not break existing samples. Fixes zephyrproject-rtos#24431 Signed-off-by: Arvin Farahmand <arvinf@ip-logix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
http_client.cusesstrlen(inhttp_send_data) to calculate requestpayloadsize, instead of usingpayload_lenthat is provided by the user. This is incorrect and results in writing fewer bytes than is expected by the server whenpayloadis binary.An additional issue is that when
payload_cbis used by the user to provide data via callback, noContent-Lengthis sent byhttp_clientevent ifpayload_lenis provided. By the timepayload_cbis invoked to provide the data the request headers have already been sent.The text was updated successfully, but these errors were encountered: