Skip to content

Commit

Permalink
fix(storybook): only install react deps for storybook 7 #29213
Browse files Browse the repository at this point in the history
  • Loading branch information
Coly010 committed Dec 6, 2024
1 parent cc14411 commit ac09f6c
Showing 1 changed file with 15 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,21 @@ export function ensureDependencies(
packageJson.dependencies ??= {};
packageJson.devDependencies ??= {};

// Needed for Storybook 7
// https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#react-peer-dependencies-required
if (
!packageJson.dependencies['react'] &&
!packageJson.devDependencies['react']
) {
dependencies['react'] = reactVersion;
}
if (
!packageJson.dependencies['react-dom'] &&
!packageJson.devDependencies['react-dom']
) {
dependencies['react-dom'] = reactVersion;
if (!gte(storybook7VersionToInstall, '8.0.0')) {
// Needed for Storybook 7
// https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#react-peer-dependencies-required
if (
!packageJson.dependencies['react'] &&
!packageJson.devDependencies['react']
) {
dependencies['react'] = reactVersion;
}
if (
!packageJson.dependencies['react-dom'] &&
!packageJson.devDependencies['react-dom']
) {
dependencies['react-dom'] = reactVersion;
}
}

if (options.uiFramework) {
Expand Down

0 comments on commit ac09f6c

Please sign in to comment.