You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
## Current Behavior
Storybook 7 requires `react` and `react-dom` to be installed as they are
peer deps of the storybook package.
Storybook 8 does not require these deps to be installed as they are now
bundled correctly into storybook
## Expected Behavior
When user's version of storybook < 8, install `react` and `react-dom`,
otherwise, do not.
## Related Issue(s)
Fixes#29213
(cherry picked from commit 51cf34f)
Current Behavior
Thanks for nx, it's great!
My previous issue #28654 was erroneously closed with an untrue remark that Storybook requires React. It does not.
As of Storybook 8, Storybook no longer requires React in non-React projects (scroll down to "No more React requirement in non-React projects"). nx supports Storybook 8.
Every time we add storybook to an nx lib in our Angular monorepo, nx adds React to it, so we have to clean it up.
Expected Behavior
No packages should be installed.
GitHub Repo
https://github.com/prewk/nx-storybook-test
Steps to Reproduce
I've created a lib called foo in the repro repo.
npx nx g @nx/angular:storybook-configuration foo
It'll install React (and some other packages but that makes sense)
Nx Report
Failure Logs
Package Manager Version
yarn v4.4.0 / npm 10.8.2
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: