Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@nx/playwright ignoring --project argument #26965

Closed
1 of 4 tasks
MillerSvt opened this issue Jul 17, 2024 · 8 comments · Fixed by #29107
Closed
1 of 4 tasks

@nx/playwright ignoring --project argument #26965

MillerSvt opened this issue Jul 17, 2024 · 8 comments · Fixed by #29107
Assignees
@Coly010
Labels
blocked: more info needed scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: bug

Comments

@MillerSvt
Copy link

MillerSvt commented Jul 17, 2024 •
edited
Loading

Current Behavior

nx e2e app --project=chromium
Runs all tests, ignoring the --project parameter

Expected Behavior

Runs only tests in the chromium project

GitHub Repo

#26965 (comment)

Steps to Reproduce

  1. Create angular application with playwright as e2e test runner
  2. Create e2e test
  3. Add some projects for different browsers in playwright.config.ts
  4. Run nx e2e app --project=some-project

Nx Report

nx report

 NX   Report complete - copy this into the issue template

Node   : 20.12.2
OS     : darwin-arm64
npm    : 10.5.0

nx              : 18.3.5
@nx/js          : 18.3.5
@nx/jest        : 18.3.5
@nx/linter      : 18.3.5
@nx/eslint      : 18.3.5
@nx/workspace   : 18.3.5
@nx/angular     : 18.3.5
@nx/devkit      : 18.3.5
@nx/playwright  : 18.3.5
@nrwl/tao       : 18.3.5
@nx/web         : 18.3.5
@nx/webpack     : 18.3.5
typescript      : 5.4.5
---------------------------------------
Community plugins:
@jsverse/transloco         : 7.4.2
@ngrx/effects              : 17.0.1
@ngrx/entity               : 17.0.1
@ngrx/store                : 17.0.1
@ngrx/store-devtools       : 17.0.1
@taiga-ui/cdk              : 3.84.0
@taiga-ui/core             : 3.84.0
@taiga-ui/proprietary-core : 3.84.0

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response
@FrozenPandaz FrozenPandaz added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Jul 18, 2024
@Coly010
Copy link
Contributor

Coly010 commented Jul 26, 2024

Hey, can you retry this with the latest of Nx (19.5)?

If it still doesn't work, could you provide a repo with a minimal reproduction, it would be super helpful.

@Coly010 Coly010 added blocked: repro needed blocked: retry with latest Retry with latest release or head. labels Jul 26, 2024
@MillerSvt
Copy link
Author

MillerSvt commented Jul 30, 2024 •
edited
Loading

Repo: https://github.com/MillerSvt/nx-playwright-bug-repro
Command: nx e2e app-e2e --project=chromium
Result:

  3 failed
    [chromium] › example.spec.ts:3:5 › has title ───────────────────────────────────────────────────
    [firefox] › example.spec.ts:3:5 › has title ────────────────────────────────────────────────────
    [webkit] › example.spec.ts:3:5 › has title ─────────────────────────────────────────────────────

Workaround: playwright test -c app-e2e --project=chromium
Result:

  1 failed
    [chromium] › example.spec.ts:3:5 › has title ───────────────────────────────────────────────────

@MillerSvt
Copy link
Author

Could you fix it for version 18 as well?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

This issue has been automatically marked as stale because no reproduction was provided within 7 days.
Please help us help you. Providing a repository exhibiting the issue helps us diagnose and fix the issue.
Any time that we spend reproducing this issue is time taken away from addressing this issue and other issues.
This issue will be closed in 21 days if a reproduction is not provided.
If a reproduction has been provided, please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Aug 8, 2024
@MillerSvt
Copy link
Author

@Coly010 what?

@github-actions github-actions bot removed the stale label Aug 9, 2024
@Coly010 Coly010 removed blocked: repro needed blocked: retry with latest Retry with latest release or head. labels Aug 12, 2024
@Coly010
Copy link
Contributor

Coly010 commented Nov 28, 2024

@MillerSvt Can you try nx e2e app-e2e -- --project=chromium

Note the additional -- to pass the arg to the underlying tool rather than be consumed by Nx

@MillerSvt
Copy link
Author

Can you try nx e2e app-e2e -- --project=chromium

It worked. Thank you!

It would be nice to reflect this nuance in the documentation, because all other parameters work without additional --

@Coly010
Copy link
Contributor

Coly010 commented Nov 28, 2024

Yeah, this one is kind of a "special case" because Nx CLI has an arg called project also.

@Coly010 Coly010 mentioned this issue Nov 28, 2024
Merged
Coly010 added a commit that referenced this issue Nov 28, 2024
@Coly010
docs(testing): add example of using Playwright's --project argument w…
c66b99c 
…ith Nx (#29107)

## Current Behavior
Missing documentation on how to use Playwright's `--project` argument
with Nx.
Because Nx also has a `--project` argument, passing it to the command
like `nx e2e app --project=firefox` will result in the `--project` being
stripped from the command that is sent to Playwright.


## Expected Behavior
The fix is simple enough, change the command to be `nx e2e app --
--project=firefox` to ensure the argument is forwarded correctly to
Playwright.
Add some information to the Playwright plugin's overview documentation
to explain this.


## Related Issue(s)

Fixes #26965
FrozenPandaz pushed a commit that referenced this issue Nov 28, 2024
@Coly010 @FrozenPandaz
docs(testing): add example of using Playwright's --project argument w…
6fbb56c 
…ith Nx (#29107)

## Current Behavior
Missing documentation on how to use Playwright's `--project` argument
with Nx.
Because Nx also has a `--project` argument, passing it to the command
like `nx e2e app --project=firefox` will result in the `--project` being
stripped from the command that is sent to Playwright.

## Expected Behavior
The fix is simple enough, change the command to be `nx e2e app --
--project=firefox` to ensure the argument is forwarded correctly to
Playwright.
Add some information to the Playwright plugin's overview documentation
to explain this.

## Related Issue(s)

Fixes #26965

(cherry picked from commit c66b99c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Coly010 Coly010

Labels
blocked: more info needed scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(testing): add example of using Playwright's --project argument with Nx nrwl/nx
3 participants
@FrozenPandaz @Coly010 @MillerSvt