docs(testing): add example of using Playwright's --project argument with Nx #29107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 86a97b6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 28, 2024
…ith Nx (#29107) ## Current Behavior Missing documentation on how to use Playwright's `--project` argument with Nx. Because Nx also has a `--project` argument, passing it to the command like `nx e2e app --project=firefox` will result in the `--project` being stripped from the command that is sent to Playwright. ## Expected Behavior The fix is simple enough, change the command to be `nx e2e app -- --project=firefox` to ensure the argument is forwarded correctly to Playwright. Add some information to the Playwright plugin's overview documentation to explain this. ## Related Issue(s) Fixes #26965 (cherry picked from commit c66b99c)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Missing documentation on how to use Playwright's
--projectargument with Nx.Because Nx also has a
--projectargument, passing it to the command likenx e2e app --project=firefoxwill result in the--projectbeing stripped from the command that is sent to Playwright.Expected Behavior
The fix is simple enough, change the command to be
nx e2e app -- --project=firefoxto ensure the argument is forwarded correctly to Playwright.Add some information to the Playwright plugin's overview documentation to explain this.
Related Issue(s)
Fixes #26965