fix(core): handle sync generator failures #27650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f6c6e6d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
core/handle-sync-generators-failures
branch
5 times, most recently
from
b34ae7e
to
45438d4
Compare
leosvelperez
requested review from
xiongemi,
JamesHenry and
FrozenPandaz
and removed request for
xiongemi
leosvelperez
force-pushed
the
core/handle-sync-generators-failures
branch
2 times, most recently
from
e49b8b8
to
dfa7559
Compare
JamesHenry
requested changes
Sep 10, 2024
leosvelperez
force-pushed
the
core/handle-sync-generators-failures
branch
from
dfa7559
to
6c468a3
Compare
leosvelperez
force-pushed
the
core/handle-sync-generators-failures
branch
from
6c468a3
to
f6c6e6d
Compare
FrozenPandaz
approved these changes
Sep 10, 2024
JamesHenry
approved these changes
Sep 10, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Sep 12, 2024
(cherry picked from commit 4986b88)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Failures running a sync generator or flushing its changes are not handled.
Expected Behavior
Failures running a sync generator or flushing its changes should be handled.
Related Issue(s)
Fixes #