fix: add required minimizer setting to the generated Nest rspack conf… #28629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c057719. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Coly010
approved these changes
Oct 29, 2024
…ack configuration
jaysoo
pushed a commit
that referenced
this pull request
Oct 31, 2024
#28629) ## Current Behavior When using Nest.js in combination with [decorator metadata](https://docs.nestjs.com/fundamentals/execution-context#reflection-and-metadata), the class names and handlers become mangled/compressed causing them to lose the reference to the correct class/handler name. ## Expected Behavior The decorator metadata works as intended. ## Approach This PR implements a custom instance of the `SwcJsMinimizerRspackPlugin`, where the setting is modified to keep original class and function names from the `compress` and `mangle` options. ## Related I've opened a related PR on the rspack-examples repository: rspack-contrib/rspack-examples#158
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using Nest.js in combination with decorator metadata, the class names and handlers become mangled/compressed causing them to lose the reference to the correct class/handler name.
Expected Behavior
The decorator metadata works as intended.
Approach
This PR implements a custom instance of the
SwcJsMinimizerRspackPlugin, where the setting is modified to keep original class and function names from thecompressandmangleoptions.Related
I've opened a related PR on the rspack-examples repository: rspack-contrib/rspack-examples#158