chore: update Nestjs example to include minimizer options #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
pushed a commit
to nrwl/nx
that referenced
this pull request
Oct 29, 2024
#28629) ## Current Behavior When using Nest.js in combination with [decorator metadata](https://docs.nestjs.com/fundamentals/execution-context#reflection-and-metadata), the class names and handlers become mangled/compressed causing them to lose the reference to the correct class/handler name. ## Expected Behavior The decorator metadata works as intended. ## Approach This PR implements a custom instance of the `SwcJsMinimizerRspackPlugin`, where the setting is modified to keep original class and function names from the `compress` and `mangle` options. ## Related I've opened a related PR on the rspack-examples repository: rspack-contrib/rspack-examples#158
jaysoo
pushed a commit
to nrwl/nx
that referenced
this pull request
Oct 31, 2024
#28629) ## Current Behavior When using Nest.js in combination with [decorator metadata](https://docs.nestjs.com/fundamentals/execution-context#reflection-and-metadata), the class names and handlers become mangled/compressed causing them to lose the reference to the correct class/handler name. ## Expected Behavior The decorator metadata works as intended. ## Approach This PR implements a custom instance of the `SwcJsMinimizerRspackPlugin`, where the setting is modified to keep original class and function names from the `compress` and `mangle` options. ## Related I've opened a related PR on the rspack-examples repository: rspack-contrib/rspack-examples#158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Nest.js example to include minimizer options. The minimization was previously disabled, however it's possible to enable this with the right settings to allow for optimized production builds.
The main issue when using Nest.js is the ExecutionContext implementation, which retrieves class and handler values based on function names. This causes issues, for example when using this in combination with decorator metadata.