Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-federation): add comment clarifying default export in config file #28675

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 29, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@Coly010 Coly010 requested review from a team as code owners October 29, 2024 15:26
@Coly010 Coly010 requested a review from xiongemi October 29, 2024 15:26
@Coly010 Coly010 self-assigned this Oct 29, 2024
@Coly010 Coly010 requested a review from jaysoo October 29, 2024 15:26
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 5:03pm

@Coly010 Coly010 enabled auto-merge (squash) October 29, 2024 15:48
@Coly010 Coly010 merged commit 5a3fd0e into master Oct 29, 2024
6 checks passed
@Coly010 Coly010 deleted the module-federation/clarify-default-export branch October 29, 2024 17:14
jaysoo pushed a commit that referenced this pull request Oct 31, 2024
…ig file (#28675)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
Copy link

github-actions bot commented Nov 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants