Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-federation): add comment clarifying default export in config file #28675

Merged
merged 2 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,7 @@ const config: ModuleFederationConfig = {
},<% } %>
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
export default config;
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
module.exports = {
name: '<%= name %>',<% if(type === 'host') { %>
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@ const config: ModuleFederationConfig = {
],
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
export default config;
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,7 @@ const moduleFederationConfig = {
],
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
module.exports = moduleFederationConfig;
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,7 @@ const config: ModuleFederationConfig = {
],
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
export default config;
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
module.exports = {
name: '<%= projectName %>',
/**
Expand All @@ -18,4 +21,4 @@ module.exports = {
}
%>
],
};
};
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@ const config: ModuleFederationConfig = {
],
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
export default config;
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,7 @@ const moduleFederationConfig = {
],
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
module.exports = moduleFederationConfig;
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,7 @@ const config: ModuleFederationConfig = {
],
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
export default config;
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
module.exports = {
name: '<%= projectName %>',
/**
Expand All @@ -18,4 +21,4 @@ module.exports = {
}
%>
],
};
};
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,7 @@ const config: ModuleFederationConfig = {
},
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
export default config;
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
module.exports = {
name: '<%= projectName %>',
exposes: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@ const config: ModuleFederationConfig = {
},
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
export default config;
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
module.exports = {
name: '<%= projectName %>',
<% if (dynamic) { %>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,7 @@ const config: ModuleFederationConfig = {
},
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
export default config;
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
module.exports = {
name: '<%= projectName %>',
exposes: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@ const config: ModuleFederationConfig = {
},
};

/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
export default config;
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* Nx requires a default export of the config to allow correct resolution of the module federation graph.
**/
module.exports = {
name: '<%= projectName %>',
<% if (dynamic) { %>
Expand Down