fix(linter): tslint to eslint conversion should not override existing root config #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeroslav
added
type: bug
scope: angular
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/DHjrVXX8oqdXv8cZXX7owpC7wyds [Deployment for 751e886 canceled] |
meeroslav
force-pushed
the
fix/linter-partial-conversion
branch
from
6033370 to
ae02eaa
Compare
Nx Cloud ReportCI ran the following commands for commit 751e886. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
JamesHenry
reviewed
Jun 23, 2021
packages/angular/src/generators/convert-tslint-to-eslint/convert-tslint-to-eslint.ts
Show resolved
Hide resolved
meeroslav
force-pushed
the
fix/linter-partial-conversion
branch
from
37577a4 to
7c2367d
Compare
meeroslav
force-pushed
the
fix/linter-partial-conversion
branch
from
55a8881 to
751e886
Compare
meeroslav
changed the title
mmuenker
pushed a commit
to mmuenker/nx
that referenced
this pull request
Jun 28, 2021
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If projects are being converted from
tslinttoeslintone at a time and user makes changes to root.eslintrc.jsonin the meantime, those changes should not be overridden by next project's conversion.Related Issue(s)
#5912
Fixes #5912