Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storybook): upgrade to Storybook v6.3 support #6104

Merged
merged 1 commit into from
Jun 24, 2021
Merged

feat(storybook): upgrade to Storybook v6.3 support #6104

merged 1 commit into from
Jun 24, 2021

Conversation

juristr
Copy link
Member

@juristr juristr commented Jun 23, 2021 •
edited
Loading

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #5688

@vercel
Copy link

vercel bot commented Jun 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/ATUyG6FGv1CyAikUEcZkGLvMD45b
✅ Preview: https://nx-dev-git-upgrade-storybook-v63-nrwl.vercel.app

@juristr juristr linked an issue Jun 23, 2021 that may be closed by this pull request
Angular 12 and Storybook with Webpack 5 issues #5688
Closed
@nx-cloud
Copy link

nx-cloud bot commented Jun 23, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit d5314d0. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --parallel --max-parallel=3
#000000 nx affected --target=e2e
#000000 nx affected --target=lint --parallel --max-parallel=4
#000000 nx affected --target=test --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

@juristr juristr force-pushed the upgrade-storybook-v6_3 branch from 131d54c to a051564 Compare June 23, 2021 14:10
@juristr juristr self-assigned this Jun 23, 2021
@juristr juristr mentioned this pull request Jun 23, 2021
Merged
@meeroslav meeroslav mentioned this pull request Jun 23, 2021
Merged
@meeroslav meeroslav added the scope: storybook Issues related to Storybook support in Nx label Jun 23, 2021
@juristr juristr force-pushed the upgrade-storybook-v6_3 branch from a051564 to c93e2d7 Compare June 23, 2021 17:26
@juristr juristr force-pushed the upgrade-storybook-v6_3 branch from c93e2d7 to 6fa1262 Compare June 23, 2021 19:23
@juristr juristr marked this pull request as ready for review June 23, 2021 19:29
@juristr juristr force-pushed the upgrade-storybook-v6_3 branch from 6fa1262 to 5411999 Compare June 23, 2021 19:49
@juristr juristr requested a review from mandarini June 23, 2021 20:34
@juristr juristr force-pushed the upgrade-storybook-v6_3 branch from 5411999 to bb3628d Compare June 24, 2021 07:22
@mandarini
Copy link
Member

Tested it out locally and looks good to me!

@juristr juristr force-pushed the upgrade-storybook-v6_3 branch from bb3628d to d5314d0 Compare June 24, 2021 14:01
mandarini
mandarini reviewed Jun 24, 2021
View reviewed changes
packages/storybook/src/migrations/update-12-5-0/migrate-storybook-6-3.ts
'@storybook/angular',
'@storybook/react',
'@storybook/addon-knobs',
'@storybook/addon-controls',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could change this to @storybook/addon-essentials, to work with the knobs-to-controls?

mandarini
mandarini reviewed Jun 24, 2021
View reviewed changes
packages/storybook/src/migrations/update-12-5-0/migrate-storybook-6-3.spec.ts
'@storybook/angular': '^6.0.0',
'@storybook/react': '^6.0.0',
'@storybook/addon-knobs': '^6.0.0',
'@storybook/addon-controls': '^6.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could change this to @storybook/addon-essentials, to work with the knobs-to-controls?

mandarini
mandarini reviewed Jun 24, 2021
View reviewed changes
packages/storybook/src/migrations/update-12-5-0/migrate-storybook-6-3.spec.ts
).toBe('~6.3.0');
expect(
readJson(tree, 'package.json').devDependencies[
'@storybook/addon-controls'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could change this to @storybook/addon-essentials, to work with the knobs-to-controls?

mandarini
mandarini reviewed Jun 24, 2021
View reviewed changes
packages/storybook/src/migrations/update-12-5-0/migrate-storybook-6-3.spec.ts
'@storybook/angular': '~6.0.0',
'@storybook/react': '^6.0.0',
'@storybook/addon-knobs': '^6.0.0',
'@storybook/addon-controls': '^6.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could change this to @storybook/addon-essentials, to work with the knobs-to-controls?

mandarini
mandarini reviewed Jun 24, 2021
View reviewed changes
packages/storybook/src/migrations/update-12-5-0/migrate-storybook-6-3.spec.ts
'@storybook/angular': '^6.0.0',
'@storybook/react': '^6.0.0',
'@storybook/addon-knobs': '^6.0.0',
'@storybook/addon-controls': '^6.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could change this to @storybook/addon-essentials, to work with the knobs-to-controls?

mandarini
mandarini reviewed Jun 24, 2021
View reviewed changes
packages/storybook/src/migrations/update-12-5-0/migrate-storybook-6-3.spec.ts
'@storybook/angular': '^5.3.1',
'@storybook/react': '^5.3.1',
'@storybook/addon-knobs': '^5.3.1',
'@storybook/addon-controls': '^5.3.1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could change this to @storybook/addon-essentials, to work with the knobs-to-controls?

mandarini
mandarini reviewed Jun 24, 2021
View reviewed changes
packages/storybook/src/migrations/update-12-5-0/migrate-storybook-6-3.spec.ts
).toBe('^5.3.1');
expect(
readJson(tree, 'package.json').devDependencies[
'@storybook/addon-controls'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could change this to @storybook/addon-essentials, to work with the knobs-to-controls?

@vsavkin vsavkin merged commit ad9d201 into master Jun 24, 2021
mmuenker pushed a commit to mmuenker/nx that referenced this pull request Jun 28, 2021
@juristr @mmuenker
feat(storybook): upgrade to Storybook v6.3 support (nrwl#6104)
2c0a976
@bcabanes bcabanes deleted the upgrade-storybook-v6_3 branch December 10, 2021 00:19
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mandarini mandarini mandarini approved these changes

Assignees

@juristr juristr

Labels
scope: storybook Issues related to Storybook support in Nx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular 12 and Storybook with Webpack 5 issues
4 participants
@juristr @mandarini @vsavkin @meeroslav