Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: fix Unknown transaction response for gettransactionheight #2247

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Nov 9, 2021

Problem

Invalid gettransactionheight error response (it should start with a capital letter and match the getrawtransaction error response and the reference implementation).

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #2247 (3be2a22) into master (173bf0b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2247      +/-   ##
==========================================
- Coverage   83.80%   83.78%   -0.02%     
==========================================
  Files         295      295              
  Lines       28583    28583              
==========================================
- Hits        23953    23949       -4     
- Misses       3271     3273       +2     
- Partials     1359     1361       +2     
Impacted Files Coverage Δ
pkg/rpc/server/server.go 78.34% <100.00%> (ø)
pkg/services/stateroot/validators.go 76.74% <0.00%> (-8.14%) ⬇️
pkg/network/server.go 73.83% <0.00%> (+0.11%) ⬆️
pkg/consensus/consensus.go 73.15% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173bf0b...3be2a22. Read the comment docs.

pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Show resolved Hide resolved
@AnnaShaleva
Copy link
Member Author

Ref. #2248.

@roman-khimov roman-khimov added this to the v0.97.4 milestone Nov 9, 2021
@roman-khimov roman-khimov merged commit fc487ea into master Nov 9, 2021
@roman-khimov roman-khimov deleted the rpc/unknown_tx_err branch November 9, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants