Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: take care of response errors and error codes #2248

Closed
AnnaShaleva opened this issue Nov 9, 2021 · 2 comments
Closed

rpc: take care of response errors and error codes #2248

AnnaShaleva opened this issue Nov 9, 2021 · 2 comments
Assignees
Labels
rpc RPC server and client
Milestone

Comments

@AnnaShaleva
Copy link
Member

AnnaShaleva commented Nov 9, 2021

  • We should carefully distinguish all kinds of RPC errors (parameters parsing errors / handling errors / server errors / etc.) on the server side. Each meaningful error should have a separate meaningful error code.
  • All possible errors for each RPC call should be documented.
  • All possible errors should be presented as exported variables and have proper comments for external users.
  • RPC client should be able to distinguish errors by codes and should return these specific errors. Users should be able to identify them via errors.Is(...)
  • All errors and error codes should be compatible with the reference implementation, so we may add an issue about errors naming to neo-modules repo.
@AnnaShaleva AnnaShaleva added the rpc RPC server and client label Nov 9, 2021
@roman-khimov roman-khimov added this to the v0.99.0 milestone Mar 21, 2022
@roman-khimov roman-khimov modified the milestones: v0.99.0, v0.99.1 Apr 7, 2022
@roman-khimov
Copy link
Member

#2544 fixes №3 and №4, but we still need to synchronize with C#, extend the set of errors and then extend the documentation.

@AnnaShaleva
Copy link
Member Author

№1, №2 and №5 are dependent on the neo-project/neo-modules#728.

@AnnaShaleva AnnaShaleva modified the milestones: v0.99.1, v0.99.2 Jun 14, 2022
@roman-khimov roman-khimov modified the milestones: v0.99.2, v0.99.3 Jul 11, 2022
@roman-khimov roman-khimov modified the milestones: v0.99.3, v0.99.4 Sep 1, 2022
@roman-khimov roman-khimov modified the milestones: v0.99.4, v0.99.5 Sep 30, 2022
@roman-khimov roman-khimov modified the milestones: v0.99.5, v0.100.0, v0.100.1 Nov 10, 2022
@roman-khimov roman-khimov modified the milestones: v0.100.1, v0.100.2 Dec 28, 2022
@roman-khimov roman-khimov modified the milestones: v0.101.0, v0.101.1 Jan 10, 2023
@roman-khimov roman-khimov modified the milestones: v0.101.1, v0.103.0 Feb 17, 2023
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Jul 17, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
@tatiana-nspcc tatiana-nspcc self-assigned this Jul 24, 2023
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Jul 24, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Jul 24, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Jul 26, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Jul 27, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Jul 27, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 8, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 10, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 10, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 10, 2023
Function getStorage has started to return errors unlike to previous behavior: return nil instead of errors.

Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 10, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 10, 2023
Function getStorage has started to return errors unlike to previous behavior: return nil instead of errors.

Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 10, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 10, 2023
Function getStorage has started to return errors unlike to previous behavior: return nil instead of errors.

Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 10, 2023
Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 10, 2023
Function getStorage has started to return errors unlike to previous behavior: return nil instead of errors.

Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
@AnnaShaleva AnnaShaleva modified the milestones: v0.103.0, v0.102.0 Aug 14, 2023
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 16, 2023
According to proposal:
neo-project/proposals#156

Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 16, 2023
According to proposal:
neo-project/proposals#156

Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 16, 2023
According to proposal:
neo-project/proposals#156

Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit to tatiana-nspcc/neo-go that referenced this issue Aug 16, 2023
According to proposal:
neo-project/proposals#156

Close nspcc-dev#2248

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

No branches or pull requests

3 participants