-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: remove Cause field from RPC error #2544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2544 +/- ##
==========================================
- Coverage 85.01% 85.00% -0.01%
==========================================
Files 295 296 +1
Lines 37144 37175 +31
==========================================
+ Hits 31578 31602 +24
- Misses 4219 4226 +7
Partials 1347 1347
Continue to review full report at Codecov.
|
roman-khimov
reviewed
Jun 7, 2022
AnnaShaleva
force-pushed
the
rpc/remove-cause
branch
3 times, most recently
from
June 8, 2022 16:02
b2e1703
to
5f59a16
Compare
roman-khimov
reviewed
Jun 9, 2022
roman-khimov
reviewed
Jun 9, 2022
AnnaShaleva
force-pushed
the
rpc/remove-cause
branch
4 times, most recently
from
June 9, 2022 16:23
0a603e1
to
5d8a5f5
Compare
AnnaShaleva
force-pushed
the
rpc/remove-cause
branch
from
June 10, 2022 13:05
5d8a5f5
to
bae9e0c
Compare
We can use Data field for the same purposes.
It's internal server thing that is not for the outside users.
Add a few the most common ones.
Retrieve error's HTTP code in a separate method.
AnnaShaleva
force-pushed
the
rpc/remove-cause
branch
from
June 10, 2022 13:48
86e7166
to
ea6ddbe
Compare
roman-khimov
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use Data field for the same purposes.