Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: remove Cause field from RPC error #2544

Merged
merged 5 commits into from
Jun 10, 2022
Merged

Conversation

AnnaShaleva
Copy link
Member

We can use Data field for the same purposes.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #2544 (ea6ddbe) into master (7dcbfcb) will decrease coverage by 0.00%.
The diff coverage is 58.53%.

@@            Coverage Diff             @@
##           master    #2544      +/-   ##
==========================================
- Coverage   85.01%   85.00%   -0.01%     
==========================================
  Files         295      296       +1     
  Lines       37144    37175      +31     
==========================================
+ Hits        31578    31602      +24     
- Misses       4219     4226       +7     
  Partials     1347     1347              
Impacted Files Coverage Δ
pkg/rpc/server/server.go 77.51% <52.21%> (+0.09%) ⬆️
pkg/rpc/response/errors.go 69.69% <64.28%> (-13.07%) ⬇️
pkg/rpc/server/error.go 82.60% <82.60%> (ø)
pkg/core/interop/runtime/engine.go 95.52% <0.00%> (-4.48%) ⬇️
pkg/core/interop/storage/find.go 97.33% <0.00%> (-2.67%) ⬇️
pkg/core/native/ledger.go 93.16% <0.00%> (-0.86%) ⬇️
pkg/core/dao/dao.go 80.10% <0.00%> (-0.84%) ⬇️
pkg/vm/contract_checks.go 81.29% <0.00%> (-0.53%) ⬇️
pkg/core/interop/context.go 92.03% <0.00%> (-0.11%) ⬇️
pkg/network/server.go 74.11% <0.00%> (-0.10%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6cdb6...ea6ddbe. Read the comment docs.

pkg/rpc/response/errors.go Outdated Show resolved Hide resolved
pkg/rpc/response/errors.go Show resolved Hide resolved
pkg/rpc/response/errors.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva force-pushed the rpc/remove-cause branch 3 times, most recently from b2e1703 to 5f59a16 Compare June 8, 2022 16:02
pkg/rpc/response/errors.go Outdated Show resolved Hide resolved
pkg/rpc/response/errors.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/response/errors.go Outdated Show resolved Hide resolved
pkg/rpc/response/errors.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
pkg/rpc/response/errors.go Show resolved Hide resolved
@AnnaShaleva AnnaShaleva force-pushed the rpc/remove-cause branch 4 times, most recently from 0a603e1 to 5d8a5f5 Compare June 9, 2022 16:23
@AnnaShaleva AnnaShaleva marked this pull request as draft June 10, 2022 08:51
pkg/rpc/response/errors.go Outdated Show resolved Hide resolved
pkg/rpc/response/errors.go Show resolved Hide resolved
pkg/rpc/response/errors.go Show resolved Hide resolved
pkg/rpc/server/error.go Outdated Show resolved Hide resolved
pkg/rpc/server/error.go Outdated Show resolved Hide resolved
pkg/rpc/server/server.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva marked this pull request as ready for review June 10, 2022 13:29
We can use Data field for the same purposes.
It's internal server thing that is not for the outside users.
Add a few the most common ones.
Retrieve error's HTTP code in a separate method.
@roman-khimov roman-khimov added this to the v0.99.1 milestone Jun 10, 2022
@roman-khimov roman-khimov merged commit 6e47585 into master Jun 10, 2022
@roman-khimov roman-khimov deleted the rpc/remove-cause branch June 10, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants