switch flake8 -> ruff #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 17 17
Lines 1622 1622
=======================================
Hits 1484 1484
Misses 138 138 |
This was referenced Nov 21, 2023
Closed
akx
added a commit
to valohai/papermill
that referenced
this pull request
Dec 18, 2023
flake8 was dropped in nteract#752
akx
added a commit
to valohai/papermill
that referenced
this pull request
Dec 18, 2023
flake8 was dropped in nteract#752
Merged
MSeal
pushed a commit
that referenced
this pull request
Dec 18, 2023
* pre-commit: don't prescribe python 3.8 * pre-commit: get rid of yesqa, it's for flake8 only flake8 was dropped in #752 * pre-commit: use ruff's UP rules instead of pyupgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ruff has been adopted by several major projects already I would consider it as stable and offer significant performance boost and fixing multiple lints in the same time