Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch flake8 -> ruff #752

Merged
merged 7 commits into from
Nov 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,7 @@ pip-wheel-metadata

# VIM swap files
*.swp


# lint
.ruff_cache/
16 changes: 4 additions & 12 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ repos:
# - id: docformatter
# args: [--in-place, --wrap-summaries=120, --wrap-descriptions=120]

#- repo: https://github.com/PyCQA/isort
# rev: 5.10.1
# hooks:
# - id: isort

- repo: https://github.com/psf/black
rev: 23.11.0
hooks:
Expand All @@ -59,11 +54,8 @@ repos:
hooks:
- id: yesqa

- repo: https://github.com/pycqa/flake8
rev: 6.1.0
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.1.4
hooks:
- id: flake8
arge:
- "--count"
- "--show-source"
- "--statistics"
- id: ruff
args: ["--fix"]
9 changes: 4 additions & 5 deletions papermill/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .version import version as __version__

from .exceptions import PapermillException, PapermillExecutionError
from .execute import execute_notebook
from .inspection import inspect_notebook
from .exceptions import PapermillException, PapermillExecutionError # noqa: F401
from .execute import execute_notebook # noqa: F401
from .inspection import inspect_notebook # noqa: F401
from .version import version as __version__ # noqa: F401
6 changes: 3 additions & 3 deletions papermill/abs.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
"""Utilities for working with Azure blob storage"""
import re
import io
import re

from azure.storage.blob import BlobServiceClient
from azure.identity import EnvironmentCredential
from azure.storage.blob import BlobServiceClient


class AzureBlobStore:
Expand All @@ -29,7 +29,7 @@ def _blob_service_client(self, account_name, sas_token=None):
@classmethod
def _split_url(self, url):
"""
see: https://docs.microsoft.com/en-us/azure/storage/common/storage-dotnet-shared-access-signature-part-1 # noqa: E501
see: https://docs.microsoft.com/en-us/azure/storage/common/storage-dotnet-shared-access-signature-part-1
abs://myaccount.blob.core.windows.net/sascontainer/sasblob.txt?sastoken
"""
match = re.match(r"abs://(.*)\.blob\.core\.windows\.net\/(.*?)\/([^\?]*)\??(.*)$", url)
Expand Down
16 changes: 7 additions & 9 deletions papermill/cli.py
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
"""Main `papermill` interface."""

import base64
import logging
import os
import platform
import sys
from stat import S_ISFIFO
import nbclient
import traceback

import base64
import logging
from stat import S_ISFIFO

import click

import nbclient
import yaml
import platform

from .execute import execute_notebook
from .iorw import read_yaml_file, NoDatesSafeLoader
from .inspection import display_notebook_help
from . import __version__ as papermill_version
from .iorw import NoDatesSafeLoader, read_yaml_file
from .version import version as papermill_version

click.disable_unicode_literals_warning = True

Expand Down
2 changes: 1 addition & 1 deletion papermill/clientwrap.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import sys
import asyncio
import sys

from nbclient import NotebookClient
from nbclient.exceptions import CellExecutionError
Expand Down
12 changes: 6 additions & 6 deletions papermill/engines.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
"""Engines to perform different roles"""
import sys
import datetime
import dateutil

import sys
from functools import wraps

import dateutil
import entrypoints

from .log import logger
from .exceptions import PapermillException
from .clientwrap import PapermillNotebookClient
from .exceptions import PapermillException
from .iorw import write_ipynb
from .utils import merge_kwargs, remove_args, nb_kernel_name, nb_language
from .log import logger
from .utils import merge_kwargs, nb_kernel_name, nb_language, remove_args


class PapermillEngines:
Expand Down
13 changes: 7 additions & 6 deletions papermill/execute.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import nbformat
from pathlib import Path

from .log import logger
from .exceptions import PapermillExecutionError
from .iorw import get_pretty_path, local_file_io_cwd, load_notebook_node, write_ipynb
import nbformat

from .engines import papermill_engines
from .utils import chdir
from .parameterize import add_builtin_parameters, parameterize_notebook, parameterize_path
from .exceptions import PapermillExecutionError
from .inspection import _infer_parameters
from .iorw import get_pretty_path, load_notebook_node, local_file_io_cwd, write_ipynb
from .log import logger
from .parameterize import add_builtin_parameters, parameterize_notebook, parameterize_path
from .utils import chdir


def execute_notebook(
Expand Down
3 changes: 2 additions & 1 deletion papermill/inspection.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
"""Deduce parameters of a notebook from the parameters cell."""
import click
from pathlib import Path

import click

from .iorw import get_pretty_path, load_notebook_node, local_file_io_cwd
from .log import logger
from .parameterize import add_builtin_parameters, parameterize_path
Expand Down
17 changes: 8 additions & 9 deletions papermill/iorw.py
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
import fnmatch
import json
import os
import sys
import json
import yaml
import fnmatch
import nbformat
import requests
import warnings
import entrypoints

from contextlib import contextmanager

import entrypoints
import nbformat
import requests
import yaml
from tenacity import retry, retry_if_exception_type, stop_after_attempt, wait_exponential

from . import __version__
from .exceptions import (
PapermillException,
PapermillRateLimitException,
Expand All @@ -21,6 +19,7 @@
)
from .log import logger
from .utils import chdir
from .version import version as __version__

try:
from .s3 import S3
Expand Down Expand Up @@ -48,7 +47,7 @@
GCSFileSystem = missing_dependency_generator("gcsfs", "gcs")

try:
from pyarrow.fs import HadoopFileSystem, FileSelector
from pyarrow.fs import FileSelector, HadoopFileSystem
except ImportError:
HadoopFileSystem = missing_dependency_generator("pyarrow", "hdfs")

Expand Down
8 changes: 4 additions & 4 deletions papermill/parameterize.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
from datetime import datetime
from uuid import uuid4

import nbformat

from .engines import papermill_engines
from .log import logger
from .exceptions import PapermillMissingParameterException
from .iorw import read_yaml_file
from .log import logger
from .translators import translate_parameters
from .utils import find_first_tagged_cell_index

from uuid import uuid4
from datetime import datetime


def add_builtin_parameters(parameters):
"""Add built-in parameters to a dictionary of parameters
Expand Down
4 changes: 1 addition & 3 deletions papermill/s3.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
"""Utilities for working with S3."""

import os

import logging
import os
import threading
import zlib

Expand All @@ -11,7 +10,6 @@
from .exceptions import AwsError
from .utils import retry


logger = logging.getLogger('papermill.s3')


Expand Down
3 changes: 0 additions & 3 deletions papermill/tests/__init__.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import os

from io import StringIO


kernel_name = 'python3'


Expand Down
3 changes: 2 additions & 1 deletion papermill/tests/test_abs.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import os
import unittest

from unittest.mock import Mock, patch

from azure.identity import EnvironmentCredential

from ..abs import AzureBlobStore


Expand Down
7 changes: 4 additions & 3 deletions papermill/tests/test_adl.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import unittest
from unittest.mock import MagicMock, Mock, patch

from unittest.mock import Mock, MagicMock, patch

from ..adl import ADL, core as adl_core, lib as adl_lib
from ..adl import ADL
from ..adl import core as adl_core
from ..adl import lib as adl_lib


class ADLTest(unittest.TestCase):
Expand Down
4 changes: 2 additions & 2 deletions papermill/tests/test_autosave.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import nbformat
import os
import tempfile
import time
import unittest
from unittest.mock import patch

from . import get_notebook_path
import nbformat

from .. import engines
from ..engines import NotebookExecutionManager
from ..execute import execute_notebook
from . import get_notebook_path


class TestMidCellAutosave(unittest.TestCase):
Expand Down
15 changes: 7 additions & 8 deletions papermill/tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,22 @@
""" Test the command line interface """

import os
from pathlib import Path
import sys
import subprocess
import sys
import tempfile
import uuid
import nbclient

import nbformat
import unittest
import uuid
from pathlib import Path
from unittest.mock import patch

import nbclient
import nbformat
import pytest
from click.testing import CliRunner

from . import get_notebook_path, kernel_name
from .. import cli
from ..cli import papermill, _is_int, _is_float, _resolve_type
from ..cli import _is_float, _is_int, _resolve_type, papermill
from . import get_notebook_path, kernel_name


@pytest.mark.parametrize(
Expand Down
9 changes: 4 additions & 5 deletions papermill/tests/test_clientwrap.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import nbformat
import unittest

from unittest.mock import call, patch

from . import get_notebook_path
import nbformat

from ..log import logger
from ..engines import NotebookExecutionManager
from ..clientwrap import PapermillNotebookClient
from ..engines import NotebookExecutionManager
from ..log import logger
from . import get_notebook_path


class TestPapermillClientWrapper(unittest.TestCase):
Expand Down
13 changes: 6 additions & 7 deletions papermill/tests/test_engines.py
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import copy
import dateutil
import unittest

from abc import ABCMeta
from unittest.mock import Mock, patch, call
from nbformat.notebooknode import NotebookNode
from unittest.mock import Mock, call, patch

from . import get_notebook_path
import dateutil
from nbformat.notebooknode import NotebookNode

from .. import engines, exceptions
from ..log import logger
from ..engines import Engine, NBClientEngine, NotebookExecutionManager
from ..iorw import load_notebook_node
from ..engines import NotebookExecutionManager, Engine, NBClientEngine
from ..log import logger
from . import get_notebook_path


def AnyMock(cls):
Expand Down
9 changes: 4 additions & 5 deletions papermill/tests/test_execute.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,19 @@
import tempfile
import unittest
from copy import deepcopy
from unittest.mock import patch, ANY

from functools import partial
from pathlib import Path
from unittest.mock import ANY, patch

import nbformat
from nbformat import validate

from .. import engines, translators
from ..log import logger
from ..exceptions import PapermillExecutionError
from ..execute import execute_notebook
from ..iorw import load_notebook_node
from ..log import logger
from ..utils import chdir
from ..execute import execute_notebook
from ..exceptions import PapermillExecutionError
from . import get_notebook_path, kernel_name

execute_notebook = partial(execute_notebook, kernel_name=kernel_name)
Expand Down
1 change: 0 additions & 1 deletion papermill/tests/test_inspect.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

from papermill.inspection import display_notebook_help, inspect_notebook


NOTEBOOKS_PATH = Path(__file__).parent / "notebooks"


Expand Down
Loading