Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display QR-Code #14

Merged
merged 4 commits into from
Jul 13, 2021
Merged

Display QR-Code #14

merged 4 commits into from
Jul 13, 2021

Conversation

jongbonga
Copy link
Contributor

@jongbonga jongbonga commented Jul 6, 2021 •
edited by PiDelport
Loading

@jongbonga jongbonga self-assigned this Jul 6, 2021
@PiDelport PiDelport linked an issue Jul 7, 2021 that may be closed by this pull request
Add QR code scanning and display library to the frontend #5
Closed
@PiDelport PiDelport mentioned this pull request Jul 7, 2021
Closed
longtomjr
longtomjr reviewed Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Happy to merge once the test issue have been resolved.

@longtomjr longtomjr changed the title Dispay qrcode Display QR-Code Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021 •
edited
Loading

Codecov Report

Merging #14 (4515672) into main (57a24d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines           24        24           
=========================================
  Hits            24        24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a24d4...4515672. Read the comment docs.

@jongbonga jongbonga requested a review from longtomjr July 9, 2021 08:54
longtomjr
longtomjr requested changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get the lock-file sorted before merging this

@PiDelport PiDelport force-pushed the routes branch 2 times, most recently from a2de13b to dd50a19 Compare July 12, 2021 13:16
@PiDelport PiDelport force-pushed the dispay-qrcode branch 3 times, most recently from 7a87226 to e96a83e Compare July 12, 2021 21:30
@PiDelport PiDelport marked this pull request as draft July 12, 2021 21:42
Base automatically changed from routes to main July 13, 2021 09:28
@netlify
Copy link

netlify bot commented Jul 13, 2021 •
edited
Loading

✔️ Deploy Preview for nautilus-wallet ready!

🔨 Explore the source changes: 4515672

🔍 Inspect the deploy log: https://app.netlify.com/sites/nautilus-wallet/deploys/60ed606b1946a40007c277cc

😎 Browse the preview: https://deploy-preview-14--nautilus-wallet.netlify.app

@PiDelport PiDelport marked this pull request as ready for review July 13, 2021 09:50
@PiDelport PiDelport requested a review from longtomjr July 13, 2021 09:55
PiDelport
PiDelport approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@PiDelport PiDelport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, updated and looks good!

longtomjr
longtomjr approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@jongbonga jongbonga merged commit 01f4768 into main Jul 13, 2021
@jongbonga jongbonga deleted the dispay-qrcode branch July 13, 2021 10:14
@PiDelport PiDelport mentioned this pull request Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longtomjr longtomjr longtomjr approved these changes

@PiDelport PiDelport PiDelport approved these changes

@Nghondzweni Nghondzweni Awaiting requested review from Nghondzweni

Assignees

@jongbonga jongbonga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add QR code scanning and display library to the frontend
3 participants
@jongbonga @PiDelport @longtomjr