Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(web-client): npm updates, legacy-peer-deps #17

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

PiDelport
Copy link
Collaborator

I think this finally gets our npm packages into a more stable state: it looks like the Angular ecosystem isn't really ready for the stricter NPM 7 peer-dependency handling yet, and needs legacy-peer-deps for the time being.

@PiDelport PiDelport added the M: web-client Module: Web client app (Angular) label Jul 14, 2021
@PiDelport PiDelport requested review from longtomjr and jongbonga July 14, 2021 18:33
@netlify
Copy link

netlify bot commented Jul 14, 2021

✔️ Deploy Preview for nautilus-wallet ready!

🔨 Explore the source changes: 3f0e31b

🔍 Inspect the deploy log: https://app.netlify.com/sites/nautilus-wallet/deploys/60f050eb3c7e1a0007a7cb0e

😎 Browse the preview: https://deploy-preview-17--nautilus-wallet.netlify.app/

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #17 (3f0e31b) into main (b3e2735) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines           24        24           
=========================================
  Hits            24        24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e2735...3f0e31b. Read the comment docs.

@PiDelport
Copy link
Collaborator Author

@jongbonga: Let me know if this looks and works good to you, too?

@PiDelport PiDelport force-pushed the web-client/chore-npm-update branch from cf19e9d to 3f0e31b Compare July 15, 2021 15:14
@jongbonga
Copy link
Contributor

@PiDelport please remind me what exactly breaks > 12.0.4?

@PiDelport
Copy link
Collaborator Author

@jongbonga: That was the breakage we had with build:prod and build-storybook in #8, and partially fixed in ac7bc77: storybookjs/storybook#15227 (comment) narrowed the issue down to this changed, released in @angular-devkit/build-angular 12.0.4:

However, the fix in ac7bc77 required some manual package lock wrangling to avoid Angular subcomponents at different versions pulling in more than one webpack version, which triggers the problems described here:

(This happens because of Angular subcomponents using hardcoded versions for things like webpack, rather than ranges: in this case, some Angular 12.1.x component(s) pulled in webpack 5.39.1 alongside 5.38.1, which broke the build.)

To fix this more reliably, all of our Angular components must be from the same (or close enough to the same) Angular release, since those form a consistent set that Angular tests and maintains together.

(The reason for using <12.0.4 rather than just 12.0.3 is that not all Angular subcomponents necessarily update their patch versions for every Angular patch release: for example, a bunch of the @angular-eslint packages are still at 12.0.0.)

@PiDelport PiDelport merged commit 2b032bf into main Jul 16, 2021
@PiDelport PiDelport deleted the web-client/chore-npm-update branch July 23, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M: web-client Module: Web client app (Angular)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants