-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(web-client): npm updates, legacy-peer-deps #17
Conversation
✔️ Deploy Preview for nautilus-wallet ready! 🔨 Explore the source changes: 3f0e31b 🔍 Inspect the deploy log: https://app.netlify.com/sites/nautilus-wallet/deploys/60f050eb3c7e1a0007a7cb0e 😎 Browse the preview: https://deploy-preview-17--nautilus-wallet.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 24 24
=========================================
Hits 24 24 Continue to review full report at Codecov.
|
@jongbonga: Let me know if this looks and works good to you, too? |
Rebuild lock file to take legacy-peer-deps into account.
cf19e9d
to
3f0e31b
Compare
@PiDelport please remind me what exactly breaks > |
@jongbonga: That was the breakage we had with However, the fix in ac7bc77 required some manual package lock wrangling to avoid Angular subcomponents at different versions pulling in more than one webpack version, which triggers the problems described here: (This happens because of Angular subcomponents using hardcoded versions for things like webpack, rather than ranges: in this case, some Angular 12.1.x component(s) pulled in webpack 5.39.1 alongside 5.38.1, which broke the build.) To fix this more reliably, all of our Angular components must be from the same (or close enough to the same) Angular release, since those form a consistent set that Angular tests and maintains together. (The reason for using |
I think this finally gets our npm packages into a more stable state: it looks like the Angular ecosystem isn't really ready for the stricter NPM 7 peer-dependency handling yet, and needs legacy-peer-deps for the time being.