-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(web-client): add prettier #9
Conversation
PiDelport
commented
Jun 29, 2021
•
edited
Loading
edited
- Create frontend codebase scaffolding #3
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 8 8
=========================================
Hits 8 8
Continue to review full report at Codecov.
|
@jongbonga: Does this work for your setup? |
72a0867
to
0eec038
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier literally changed the whole app init linting like "Angular CLI doesn't know what they were doing by initiating the project that way, let's fix it our way which is the right way"
They are so many things in this config that are not sitting well with me...
"src/**/*.d.ts" | ||
] | ||
"files": ["src/test.ts", "src/polyfills.ts"], | ||
"include": ["src/**/*.spec.ts", "src/**/*.d.ts"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can this be "more readable" than its previous state?
And will still break after a certain amount of characters or items anyway
Update from our standup discussion this morning: like @longtomjr, I don't really have any strong opinion about our formatting as long as we have something that lets us mechanise it, and not have to worry about manual formatting. I'd lean towards using the |
Just double checking @PiDelport. Is there anything holding this up still? |
@longtomjr: Nope, all good! |