-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Storybook #8
Conversation
Codecov Report
@@ Coverage Diff @@
## web-client/build-add-prettier #8 +/- ##
===============================================================
Coverage 100.00% 100.00%
===============================================================
Files 4 4
Lines 8 8
===============================================================
Hits 8 8 Continue to review full report at Codecov.
|
6d77d9c
to
3760107
Compare
Hmm, it looks like one of the Storybook dependencies in 9e7dc54 breaks I'll investigate. |
InvestigationIt looks like this is one those npm issues… 🤦🏼♀️ At first, I had trouble reproducing this reliably: a normal In theory, the result of those two commands should be the same, but they're not. To inspect closer, 🕵🏼♀️ I compared snapshots of the working and non-working It looks like something went wrong in "cssnano-utils": {
"version": "2.0.1",
- "resolved": "https://registry.npmjs.org/cssnano-utils/-/cssnano-utils-2.0.1.tgz",
- "integrity": "sha512-i8vLRZTnEH9ubIyfdZCAdIdgnHAUeQeByEeQ2I7oTilvP9oHO6RScpeq3GsFUVqeB8uZgOQ9pw8utofNn32hhQ==",
+ "resolved": "https://registry.npmjs.org/postcss-values-parser/-/postcss-values-parser-2.0.1.tgz",
+ "integrity": "sha512-2tLuBsA6P4rYTNKCXYG/71C7j1pU6pK503suYOmn4xYrQIzW+opD+7FAFNuGSdZC/3Qfy334QbeMu7MEb8gOxg==",
"dev": true,
- "requires": {}
+ "requires": {
+ "flatten": "^1.0.2",
+ "indexes-of": "^1.0.1",
+ "uniq": "^1.0.1"
+ }
}, This could have happened due to some npm resolution weirdness, or a particularly unlucky automatic mis-merge alignment, or something else? I'll try to fix this by replaying the dependency additions in a separate commit. |
That fixed it! 🎉 Diff: 3760107..bb95236 |
c9e9a7b
to
ddf3989
Compare
Steps: 1. `npx sb init` 2. Fix @angular/elements version to ~12.0.1 (to match the others) 3. `npm run format` 4. Undo tsconfig.app.json comment removal 5. Skip committing the default example stories
…config For now, just use the recommended defaults from: https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin
This avoids pulling in the generated "www" directory, among others.
This avoids leaving a documentation.json in the root.
This actually lets Storybook stories type-check more easily.
npm install --save-dev chromatic
…12.0.4+ @angular-devkit/build-angular 12.0.4+ makes build-storybook hang. Constraining it to 12.0.3 avoids the hang. Upstream issue, and workaround: storybookjs/storybook#15227 (comment) Also jump through some hoops to downgrade webpack from 5.39.1 to 5.38.1, to match the exact dependency expected by @angular-devkit/build-angular, and avoid this problem: angular/angular-cli#20773
Issues:
Depends on: